From: Robby Zambito <contact@robbyzambito.me>
To: 50084@debbugs.gnu.org
Cc: Robby Zambito <contact@robbyzambito.me>
Subject: [bug#50084] [PATCH v2] gnu: waypipe: Enable tests.
Date: Wed, 18 Aug 2021 16:27:11 -0400 [thread overview]
Message-ID: <20210818202710.55244-1-contact@robbyzambito.me> (raw)
In-Reply-To: <20210817015308.353224-1-contact@robbyzambito.me>
* gnu/packages/xdisorg.scm (waypipe): Don't skip tests. Add dependencies
required to run the tests.
---
This is my first contribution to guix, I was not aware of how to do what
was needed to properly pass the tests for this package. After consulting
#guix on IRC, I have believe I have made the necessary changes.
gnu/packages/xdisorg.scm | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index d79f580b47..ba520d35ae 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -881,13 +881,24 @@ include cursor in the resulting image.")
(sha256
(base32 "1qa47ljfvb1vv3h647xwn1j5j8gfmcmdfaz4j8ygnkvj36y87vnz"))))
(build-system meson-build-system)
- ;; One test fails where the program does not exit cleanly given a bad
- ;; setup. Not ideal but probably safe to ignore. Check that no other tests
- ;; fail before bumping the version. If all tests pass, remove this.
(arguments
`(#:phases
(modify-phases %standard-phases
- (delete 'check))))
+ (add-after 'unpack 'fix-sleep-path
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out"))
+ (coreutils (assoc-ref inputs "coreutils")))
+ (substitute* "./test/startup_failure.py"
+ (("sleep")
+ (string-append coreutils "/bin/sleep")))
+ #t))))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("scdoc" ,scdoc)))
+ (inputs
+ ;; For tests
+ `(("python" ,python)
+ ("coreutils" ,coreutils)))
(home-page "https://gitlab.freedesktop.org/mstoeckl/waypipe")
(synopsis "Proxy for Wayland protocol applications")
(description "Waypipe is a proxy for Wayland clients, with the aim of
--
2.32.0
next prev parent reply other threads:[~2021-08-18 20:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 1:53 [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-18 20:27 ` Robby Zambito [this message]
2021-08-19 2:02 ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Robby Zambito
2021-08-19 4:04 ` Paul A. Patience
2021-08-19 15:24 ` Maxime Devos
2021-08-19 19:58 ` Robby Zambito
2021-08-19 21:13 ` Maxime Devos
2021-08-18 22:56 ` [bug#50084] [PATCH] gnu: Add waypipe Paul A. Patience
2021-08-19 22:11 ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Robby Zambito
2021-08-30 1:54 ` [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-30 1:58 ` Robby Zambito
2021-09-06 9:15 ` bug#50084: " Nicolas Goaziou
2021-09-07 21:13 ` [bug#50084] " Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818202710.55244-1-contact@robbyzambito.me \
--to=contact@robbyzambito.me \
--cc=50084@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).