From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iudTFdh3HmGlCgEAgWs5BA (envelope-from ) for ; Thu, 19 Aug 2021 17:25:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aFBuENh3HmHMAgAAbx9fmQ (envelope-from ) for ; Thu, 19 Aug 2021 15:25:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A6B92085C for ; Thu, 19 Aug 2021 17:25:11 +0200 (CEST) Received: from localhost ([::1]:42146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGjuo-0007kS-8q for larch@yhetil.org; Thu, 19 Aug 2021 11:25:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGjug-0007kD-63 for guix-patches@gnu.org; Thu, 19 Aug 2021 11:25:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGjuf-0003Lk-PA for guix-patches@gnu.org; Thu, 19 Aug 2021 11:25:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mGjuf-0007ue-LG for guix-patches@gnu.org; Thu, 19 Aug 2021 11:25:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Aug 2021 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50084 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Robby Zambito , 50084@debbugs.gnu.org Cc: paul@apatience.com Received: via spool by 50084-submit@debbugs.gnu.org id=B50084.162938666930362 (code B ref 50084); Thu, 19 Aug 2021 15:25:01 +0000 Received: (at 50084) by debbugs.gnu.org; 19 Aug 2021 15:24:29 +0000 Received: from localhost ([127.0.0.1]:60657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGju9-0007te-At for submit@debbugs.gnu.org; Thu, 19 Aug 2021 11:24:29 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:58860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGju7-0007tU-3G for 50084@debbugs.gnu.org; Thu, 19 Aug 2021 11:24:28 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by baptiste.telenet-ops.be with bizsmtp id jTQQ2500P0mfAB401TQRwm; Thu, 19 Aug 2021 17:24:25 +0200 Message-ID: <08627decd152bee69410912cf5ac139af47dcee7.camel@telenet.be> From: Maxime Devos Date: Thu, 19 Aug 2021 17:24:09 +0200 In-Reply-To: <20210819020234.642522-1-contact@robbyzambito.me> References: <20210818202710.55244-1-contact@robbyzambito.me> <20210819020234.642522-1-contact@robbyzambito.me> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-VW4x4wRvMXvAd4wVMDon" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1629386665; bh=bO3PS0Oq81X61+laUUxiNivdWH+oR/o+TVSDmYdyh2Q=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Okknr13qbS963VI2okecLlgIWYiEWiXP4FlfSZuV6dqGaz/suabVB2ZO6651/1aOO ejRFA59jrXtOY2I3X2+QNHIWE76rROrxpuFApNdpwUqamEdwCtqEMcnKlFgqXM0OUp Nd4FvrFNS8It+p6P+zL3VjqoA8f23lVNLwJvGK19CVfFqciaX3HROw33dhoz1r6ekm EbHZ1Gy803+HC8X089fEMmCe5tZCHIEg54bKBCokbC3UR1CzZYONI7SaA6D4dGDArZ eUQQFhPt+GFgEsSwZD7RIaA324q4EfGF/x1SQRbKj1xPm8D+1DSyEf9ZfJ1Sj+wZEz zrtp9Hh9MUPNg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629386711; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=bO3PS0Oq81X61+laUUxiNivdWH+oR/o+TVSDmYdyh2Q=; b=rLPA9SMOPryhBTcvpTpxCm0Y4jzWtcn4pH5+fIGLsZu5aBqdiMCf3FUcM0tL+qhDC7EOD6 S3xmVXFfbVasuJe7YyTA+HWeQnB/aJ8EGlrAXKk3BXt5W4VQvlflSMk/4Yo7cRPcZn4QkY mrxdHmP5AZBt8SFTNgPAJU66WI32HSzPrQM/DvDcfpGonxRFqNCE7tHVIXInN8jVxgQmHN S9zyFGGFzFMpxNmOKWMU6ISVpsO6lSryI33JVac66aJAteFwC1wogeyOPHxYZ2nsfwPvSD 2Wxdq/sPk6p5XXG40FjvXvRBbx2saGNRciyMFHrvkETkTyCY29foVpD5ze3oZw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629386711; a=rsa-sha256; cv=none; b=q3DfACCoIb9Olifiex1pj1kiK2/JEpKpvMNZiGEex4eWeeQXmXBkYifOAhNOmd74OnLbAN Uztxmstbkb0waRI0bA06mVUJvOBPqprN+X3q5w8W7CTL/UgPRd+IHAFBYkMp5OSIV3bYuh zIWmd74vm1Vwj5HribBcalAPW3yGl363wuYRsz06LGj6dyVW6ZzVbGf0AA9ECEnYklAIEr wM6oisQP1LwFlq4TE/W5XyyI6k/By1H5FnD+G+bpx+g+3sIrXNjgufUq0hCPZsnObbNCp+ RUl21zUVCarybWU67DF7st0izTCPu71I70MhVgzVado6w6aI+rVF9339Mw63SQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=Okknr13q; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=Okknr13q; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6A6B92085C X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: gbyPhTo9x7hF --=-VW4x4wRvMXvAd4wVMDon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Robby Zambito schreef op wo 18-08-2021 om 22:02 [-0400]: > * gnu/packages/xdisorg.scm (waypipe)[arguments]: Remove unused > argument from fix-sleep-path phase. > [native-inputs]: Add python, coreutils. > [inputs]: Remove python, coreutils. > --- > Paul, >=20 > Thank you for the tips. I've removed the unused outputs argument, as > well as the out variable. >=20 > I'm a bit confused as to why test dependencies are supposed to be > native-inputs. Aren't the tests run on the target architecture, not the > build machine architecture? And aren't native-inputs built for the build > machine architecture? By default, tests are never run when cross-compiling, so putting test dependencies in 'native-inputs' works in practice. Theoretically, putting test dependencies in 'inputs' might be cleaner, especially if at some point Guix supports testing cross-compiled packages (maybe the build directory could be copied to a "worktree" output or something, and guix could provide a command to test the cross-compiled binaries on the machine that was cross-compiled for or something). Nevertheless, test dependencies tend to be put in 'native-input' anyways. This has a practical reason (*): not all build systems support cross-compilation. E.g., the build system 'meson', used by 'glib', doesn't support cross-compilation on 'master' (it does on 'core-updates-frozen' tho= ugh), so packages that (indirectly) have 'glib' as 'input' cannot be an 'input'. (*) not necessarily the reason people originally had in mind.=20 > I cross compiled the package for armhf-linux and aarch64-linux and it > built and tested fine with the changes you suggested, but I also did the Are you sure it tested? Unless qemu transparent emulation is enabled (see =E2=80=98Transparent Emulation with QEMU=E2=80=99 in the manual) that = cannot happen. Greetings, Maxime. --=-VW4x4wRvMXvAd4wVMDon Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYR53mRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lNnAQCYztjHjj8wOCvV6np2hGGlEfEu K6rQIIyrcHCtgpmBHwD/X1PYQ9SYjkpvYT8hIrcd2snutjulXB00RTh6/DfhpQs= =hDb2 -----END PGP SIGNATURE----- --=-VW4x4wRvMXvAd4wVMDon--