unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Paul A. Patience" <paul@apatience.com>
To: "50084@debbugs.gnu.org" <50084@debbugs.gnu.org>
Subject: [bug#50084] [PATCH] gnu: Add waypipe.
Date: Wed, 18 Aug 2021 22:56:57 +0000	[thread overview]
Message-ID: <ZScZmV8iTXYfnvQdRReLqyKZMjkTOjhY-tiR9uASSNsHgr9V8CYLZ0zQRzMBYz9Ite9mvhNFXC5q3pDVgZqMTcpnnVGOqRx-I9b1mj5EPK4=@apatience.com> (raw)
In-Reply-To: <20210817015308.353224-1-contact@robbyzambito.me>

Hi,

> +         (add-after 'unpack 'fix-sleep-path
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out"))

out is not used anywhere, so you can remove it, along with the outputs
argument of the lambda.

> +                   (coreutils (assoc-ref inputs "coreutils")))
> +               (substitute* "./test/startup_failure.py"
> +                 (("sleep")
> +                  (string-append coreutils "/bin/sleep")))
> +               #t))))))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("scdoc" ,scdoc)))
> +    (inputs
> +     ;; For tests
> +     `(("python" ,python)
> +       ("coreutils" ,coreutils)))

I haven't tried building this or anything, but if python and coreutils
are really only needed for tests, then they need not be in inputs (and
the fact that the initial version of this patch didn't have them at all
supports this thesis).
In other words, I'd put everything in native-inputs.

Also (and this is really minor), arguments normally follows the inputs
sections.

Best regards,
Paul





  parent reply	other threads:[~2021-08-18 22:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  1:53 [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-18 20:27 ` [bug#50084] [PATCH v2] gnu: waypipe: Enable tests Robby Zambito
2021-08-19  2:02   ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Robby Zambito
2021-08-19  4:04     ` Paul A. Patience
2021-08-19 15:24     ` Maxime Devos
2021-08-19 19:58       ` Robby Zambito
2021-08-19 21:13         ` Maxime Devos
2021-08-18 22:56 ` Paul A. Patience [this message]
2021-08-19 22:11 ` Robby Zambito
2021-08-30  1:54 ` [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-30  1:58   ` Robby Zambito
2021-09-06  9:15   ` bug#50084: " Nicolas Goaziou
2021-09-07 21:13   ` [bug#50084] " Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ZScZmV8iTXYfnvQdRReLqyKZMjkTOjhY-tiR9uASSNsHgr9V8CYLZ0zQRzMBYz9Ite9mvhNFXC5q3pDVgZqMTcpnnVGOqRx-I9b1mj5EPK4=@apatience.com' \
    --to=paul@apatience.com \
    --cc=50084@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).