From: Maxime Devos <maximedevos@telenet.be>
To: Robby Zambito <contact@robbyzambito.me>, 50084@debbugs.gnu.org
Subject: [bug#50084] [PATCH] gnu: Add waypipe.
Date: Tue, 07 Sep 2021 23:13:04 +0200 [thread overview]
Message-ID: <74368391c4c5ddee6ddde4a908f15c52f1a543e7.camel@telenet.be> (raw)
In-Reply-To: <20210830015400.244302-1-contact@robbyzambito.me>
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
Hi,
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'fix-sleep-path
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((coreutils (assoc-ref inputs "coreutils")))
coreutils is in native-inputs, not inputs, so this needs to be:
(assoc-ref (or native-inputs inputs) "coreutils"). (native-inputs
and inputs are appended together when compiling natively, that's
why this didn't cause a build error).
> + (substitute* "./test/startup_failure.py"
> + (("sleep") (string-append coreutils "/bin/sleep")))))))))
You can write (("sleep") (which "sleep")) here.
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("scdoc" ,scdoc)
> + ;; For tests
> + ("python" ,python)
> + ("coreutils" ,coreutils)))
FWIW, coreutils is an implicit native-input of meson-build-system,
so this input isn't necessary.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
prev parent reply other threads:[~2021-09-07 21:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 1:53 [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-18 20:27 ` [bug#50084] [PATCH v2] gnu: waypipe: Enable tests Robby Zambito
2021-08-19 2:02 ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Robby Zambito
2021-08-19 4:04 ` Paul A. Patience
2021-08-19 15:24 ` Maxime Devos
2021-08-19 19:58 ` Robby Zambito
2021-08-19 21:13 ` Maxime Devos
2021-08-18 22:56 ` [bug#50084] [PATCH] gnu: Add waypipe Paul A. Patience
2021-08-19 22:11 ` [bug#50084] [PATCH v3] gnu: waypipe: Clean up phases and dependencies Robby Zambito
2021-08-30 1:54 ` [bug#50084] [PATCH] gnu: Add waypipe Robby Zambito
2021-08-30 1:58 ` Robby Zambito
2021-09-06 9:15 ` bug#50084: " Nicolas Goaziou
2021-09-07 21:13 ` Maxime Devos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74368391c4c5ddee6ddde4a908f15c52f1a543e7.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=50084@debbugs.gnu.org \
--cc=contact@robbyzambito.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).