[PATCH 01/19] gnu: Add r-assertthat.

[PATCH 01/19] gnu: Add r-assertthat.

[Vicente Vera]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0001-gnu-Add-r-assertthat.patch --]
[-- Type: text/x-patch, Size: 1572 bytes --]

From 3c84aed40d729a2de02e891fa43c1000cec6d602 Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Sun, 13 Sep 2015 13:03:01 -0300
Subject: [PATCH 01/19] gnu: Add r-assertthat.

* gnu/packages/statistics.scm (r-assertthat): New variable.
---
 gnu/packages/statistics.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 29cd34a..9063496 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -498,3 +498,23 @@ by step from multiple data sources.  It also implements a sophisticated
 multidimensional conditioning system and a consistent interface to map data to
 aesthetic attributes.")
     (license license:gpl2+)))
+
+(define-public r-assertthat
+  (package
+    (name "r-assertthat")
+    (version "0.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://cran/src/contrib/assertthat_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32 "0dwsqajyglfscqilj843qfqn1ndbqpswa7b4l1d633qjk9d68qqk"))))
+    (build-system r-build-system)
+    (home-page "https://github.com/hadley/assertthat")
+    (synopsis "Easy pre and post assertions")
+    (description
+     "Assertthat is an extension to stopifnot() that makes it easy to
+declare the pre and post conditions that you code should satisfy,
+while also producing friendly error messages so that your users know
+what they've done wrong.")
+    (license license:gpl3+)))
-- 
2.5.1

Re: [PATCH 01/19] gnu: Add r-assertthat.

[Ricardo Wurmus]

Thank you very much for these patches!  Did you use the CRAN importer
for them?

You should add your name to the copyright header at the top of the file
(maybe as part of the first patch).

> * gnu/packages/statistics.scm (r-assertthat): New variable.

[...]

> +              (uri (string-append "mirror://cran/src/contrib/assertthat_"
> +                                  version ".tar.gz"))

I wonder if new patches should already contain the archive URI in
addition to the default URI.  It was pointed out in a previous thread
that the simple URI produced by the importer is only valid for the
latest version.

> +    (description
> +     "Assertthat is an extension to stopifnot() that makes it easy to
> +declare the pre and post conditions that you code should satisfy,

s/you code/your code/

> +while also producing friendly error messages so that your users know
> +what they've done wrong.")

~~ Ricardo

Re: [PATCH 01/19] gnu: Add r-assertthat.

[Thompson, David]

On Sun, Sep 13, 2015 at 4:04 PM, Ricardo Wurmus <rekado@elephly.net> wrote:
>> +              (uri (string-append "mirror://cran/src/contrib/assertthat_"
>> +                                  version ".tar.gz"))
>
> I wonder if new patches should already contain the archive URI in
> addition to the default URI.  It was pointed out in a previous thread
> that the simple URI produced by the importer is only valid for the
> latest version.

I would recommend creating a 'cran-uri' procedure to avoid having to
do this everywhere manually.

- Dave

Re: [PATCH 01/19] gnu: Add r-assertthat.

[Ricardo Wurmus]

Thompson, David <dthompson2@worcester.edu> writes:

> On Sun, Sep 13, 2015 at 4:04 PM, Ricardo Wurmus <rekado@elephly.net> wrote:
>>> +              (uri (string-append "mirror://cran/src/contrib/assertthat_"
>>> +                                  version ".tar.gz"))
>>
>> I wonder if new patches should already contain the archive URI in
>> addition to the default URI.  It was pointed out in a previous thread
>> that the simple URI produced by the importer is only valid for the
>> latest version.
>
> I would recommend creating a 'cran-uri' procedure to avoid having to
> do this everywhere manually.

Yes, this makes even more sense now.  I can only resume work on this by
the end of the week, unfortunately.

~~ Ricardo

Re: [PATCH 01/19] gnu: Add r-assertthat.

[Vicente Vera]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

Hi Ricardo,

CRAN importer? Hmm, just made a very useful discovery! I feel ashamed now.

Attached goes the 1st patch with the modified copyright header and the
fixed typo (actually, it came with the package description in CRAN).


2015-09-13 17:04 GMT-03:00 Ricardo Wurmus <rekado@elephly.net>:
> Thank you very much for these patches!  Did you use the CRAN importer
> for them?
>
> You should add your name to the copyright header at the top of the file
> (maybe as part of the first patch).
>
>> * gnu/packages/statistics.scm (r-assertthat): New variable.
>
> [...]
>
>> +              (uri (string-append "mirror://cran/src/contrib/assertthat_"
>> +                                  version ".tar.gz"))
>
> I wonder if new patches should already contain the archive URI in
> addition to the default URI.  It was pointed out in a previous thread
> that the simple URI produced by the importer is only valid for the
> latest version.
>
>> +    (description
>> +     "Assertthat is an extension to stopifnot() that makes it easy to
>> +declare the pre and post conditions that you code should satisfy,
>
> s/you code/your code/
>
>> +while also producing friendly error messages so that your users know
>> +what they've done wrong.")
>
> ~~ Ricardo
>

[-- Attachment #2: 0001-gnu-Add-r-assertthat.patch --]
[-- Type: text/x-patch, Size: 1804 bytes --]

From cdf4822e9c7578465ee97f0d2e23fdb80c135eee Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Sun, 13 Sep 2015 19:09:59 -0300
Subject: [PATCH] gnu: Add r-assertthat.

* gnu/packages/statistics.scm (r-assertthat): New variable.
---
 gnu/packages/statistics.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 29cd34a..0c60382 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2015 Vicente Vera <vicentemvp@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -498,3 +499,23 @@ by step from multiple data sources.  It also implements a sophisticated
 multidimensional conditioning system and a consistent interface to map data to
 aesthetic attributes.")
     (license license:gpl2+)))
+
+(define-public r-assertthat
+  (package
+    (name "r-assertthat")
+    (version "0.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://cran/src/contrib/assertthat_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32 "0dwsqajyglfscqilj843qfqn1ndbqpswa7b4l1d633qjk9d68qqk"))))
+    (build-system r-build-system)
+    (home-page "https://github.com/hadley/assertthat")
+    (synopsis "Easy pre and post assertions")
+    (description
+     "Assertthat is an extension to stopifnot() that makes it easy to declare
+the pre and post conditions that your code should satisfy, while also
+producing friendly error messages so that your users know what they've done
+wrong.")
+    (license license:gpl3+)))
-- 
2.5.1

Re: [PATCH 01/19] gnu: Add r-assertthat.

[Vicente Vera]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

Updated patch attached.

2015-09-13 19:20 GMT-03:00 Vicente Vera <vicentemvp@gmail.com>:
> Hi Ricardo,
>
> CRAN importer? Hmm, just made a very useful discovery! I feel ashamed now.
>
> Attached goes the 1st patch with the modified copyright header and the
> fixed typo (actually, it came with the package description in CRAN).
>
>
> 2015-09-13 17:04 GMT-03:00 Ricardo Wurmus <rekado@elephly.net>:
>> Thank you very much for these patches!  Did you use the CRAN importer
>> for them?
>>
>> You should add your name to the copyright header at the top of the file
>> (maybe as part of the first patch).
>>
>>> * gnu/packages/statistics.scm (r-assertthat): New variable.
>>
>> [...]
>>
>>> +              (uri (string-append "mirror://cran/src/contrib/assertthat_"
>>> +                                  version ".tar.gz"))
>>
>> I wonder if new patches should already contain the archive URI in
>> addition to the default URI.  It was pointed out in a previous thread
>> that the simple URI produced by the importer is only valid for the
>> latest version.
>>
>>> +    (description
>>> +     "Assertthat is an extension to stopifnot() that makes it easy to
>>> +declare the pre and post conditions that you code should satisfy,
>>
>> s/you code/your code/
>>
>>> +while also producing friendly error messages so that your users know
>>> +what they've done wrong.")
>>
>> ~~ Ricardo
>>

[-- Attachment #2: 0001-gnu-Add-r-assertthat.patch --]
[-- Type: text/x-patch, Size: 1848 bytes --]

From 466728d373cb114b6d36ca3b373cd019a3e57a4d Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Tue, 15 Sep 2015 14:11:12 -0300
Subject: [PATCH 01/19] gnu: Add r-assertthat.

* gnu/packages/statistics.scm (r-assertthat): New variable.
---
 gnu/packages/statistics.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 29cd34a..9a73a82 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2015 Vicente Vera Parra <vicentemvp@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -498,3 +499,26 @@ by step from multiple data sources.  It also implements a sophisticated
 multidimensional conditioning system and a consistent interface to map data to
 aesthetic attributes.")
     (license license:gpl2+)))
+
+(define-public r-assertthat
+  (package
+    (name "r-assertthat")
+    (version "0.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://cran/src/contrib/assertthat_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "0dwsqajyglfscqilj843qfqn1ndbqpswa7b4l1d633qjk9d68qqk"))))
+    (build-system r-build-system)
+    (home-page
+     "https://github.com/hadley/assertthat")
+    (synopsis
+     "Easy pre and post assertions")
+    (description
+     "Assertthat is an extension to stopifnot() that makes it easy to declare
+the pre and post conditions that your code should satisfy, while also
+producing friendly error messages so that your users know what they've done
+wrong.")
+    (license license:gpl3+)))
-- 
2.5.2

Re: [PATCH 01/19] gnu: Add r-assertthat.

[Ricardo Wurmus]

> Updated patch attached.

I applied two minor changes (pulling the text for home page and the
synopsis on the same line) and pushed to master.

Thank you!

~~ Ricardo