From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 01/19] gnu: Add r-assertthat. Date: Tue, 15 Sep 2015 14:32:38 -0300 Message-ID: References: <871te29jc0.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113b1954823034051fcc91d0 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbu5w-0005Fg-OJ for guix-devel@gnu.org; Tue, 15 Sep 2015 13:32:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbu5v-00038l-JI for guix-devel@gnu.org; Tue, 15 Sep 2015 13:32:40 -0400 Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]:35289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbu5v-00037s-8s for guix-devel@gnu.org; Tue, 15 Sep 2015 13:32:39 -0400 Received: by oiww128 with SMTP id w128so99659582oiw.2 for ; Tue, 15 Sep 2015 10:32:38 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --001a113b1954823034051fcc91d0 Content-Type: text/plain; charset=UTF-8 Updated patch attached. 2015-09-13 19:20 GMT-03:00 Vicente Vera : > Hi Ricardo, > > CRAN importer? Hmm, just made a very useful discovery! I feel ashamed now. > > Attached goes the 1st patch with the modified copyright header and the > fixed typo (actually, it came with the package description in CRAN). > > > 2015-09-13 17:04 GMT-03:00 Ricardo Wurmus : >> Thank you very much for these patches! Did you use the CRAN importer >> for them? >> >> You should add your name to the copyright header at the top of the file >> (maybe as part of the first patch). >> >>> * gnu/packages/statistics.scm (r-assertthat): New variable. >> >> [...] >> >>> + (uri (string-append "mirror://cran/src/contrib/assertthat_" >>> + version ".tar.gz")) >> >> I wonder if new patches should already contain the archive URI in >> addition to the default URI. It was pointed out in a previous thread >> that the simple URI produced by the importer is only valid for the >> latest version. >> >>> + (description >>> + "Assertthat is an extension to stopifnot() that makes it easy to >>> +declare the pre and post conditions that you code should satisfy, >> >> s/you code/your code/ >> >>> +while also producing friendly error messages so that your users know >>> +what they've done wrong.") >> >> ~~ Ricardo >> --001a113b1954823034051fcc91d0 Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-Add-r-assertthat.patch" Content-Disposition: attachment; filename="0001-gnu-Add-r-assertthat.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ieln09xe1 RnJvbSA0NjY3MjhkMzczY2IxMTRiNmQzNmNhM2IzNzNjZDAxOWEzZTU3YTRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBUdWUsIDE1IFNlcCAyMDE1IDE0OjExOjEyIC0wMzAwClN1YmplY3Q6IFtQQVRD SCAwMS8xOV0gZ251OiBBZGQgci1hc3NlcnR0aGF0LgoKKiBnbnUvcGFja2FnZXMvc3RhdGlzdGlj cy5zY20gKHItYXNzZXJ0dGhhdCk6IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvc3Rh dGlzdGljcy5zY20gfCAyNCArKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2Vk LCAyNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Mu c2NtIGIvZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtCmluZGV4IDI5Y2QzNGEuLjlhNzNhODIg MTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbQorKysgYi9nbnUvcGFja2Fn ZXMvc3RhdGlzdGljcy5zY20KQEAgLTEsNSArMSw2IEBACiA7OzsgR05VIEd1aXggLS0tIEZ1bmN0 aW9uYWwgcGFja2FnZSBtYW5hZ2VtZW50IGZvciBHTlUKIDs7OyBDb3B5cmlnaHQgwqkgMjAxNSBS aWNhcmRvIFd1cm11cyA8cmVrYWRvQGVsZXBobHkubmV0PgorOzs7IENvcHlyaWdodCDCqSAyMDE1 IFZpY2VudGUgVmVyYSBQYXJyYSA8dmljZW50ZW12cEBnbWFpbC5jb20+CiA7OzsKIDs7OyBUaGlz IGZpbGUgaXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtNDk4LDMgKzQ5OSwyNiBAQCBieSBz dGVwIGZyb20gbXVsdGlwbGUgZGF0YSBzb3VyY2VzLiAgSXQgYWxzbyBpbXBsZW1lbnRzIGEgc29w aGlzdGljYXRlZAogbXVsdGlkaW1lbnNpb25hbCBjb25kaXRpb25pbmcgc3lzdGVtIGFuZCBhIGNv bnNpc3RlbnQgaW50ZXJmYWNlIHRvIG1hcCBkYXRhIHRvCiBhZXN0aGV0aWMgYXR0cmlidXRlcy4i KQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKworKGRlZmluZS1wdWJsaWMgci1hc3Nl cnR0aGF0CisgIChwYWNrYWdlCisgICAgKG5hbWUgInItYXNzZXJ0dGhhdCIpCisgICAgKHZlcnNp b24gIjAuMSIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAgIChtZXRob2QgdXJs LWZldGNoKQorICAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJtaXJyb3I6Ly9jcmFu L3NyYy9jb250cmliL2Fzc2VydHRoYXRfIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHZlcnNpb24gIi50YXIuZ3oiKSkKKyAgICAgICAgICAgICAgKHNoYTI1NgorICAgICAgICAg ICAgICAgKGJhc2UzMgorICAgICAgICAgICAgICAgICIwZHdzcWFqeWdsZnNjcWlsajg0M3FmcW4x bmRicXBzd2E3YjRsMWQ2MzNxams5ZDY4cXFrIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIHItYnVp bGQtc3lzdGVtKQorICAgIChob21lLXBhZ2UKKyAgICAgImh0dHBzOi8vZ2l0aHViLmNvbS9oYWRs ZXkvYXNzZXJ0dGhhdCIpCisgICAgKHN5bm9wc2lzCisgICAgICJFYXN5IHByZSBhbmQgcG9zdCBh c3NlcnRpb25zIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgIkFzc2VydHRoYXQgaXMgYW4gZXh0 ZW5zaW9uIHRvIHN0b3BpZm5vdCgpIHRoYXQgbWFrZXMgaXQgZWFzeSB0byBkZWNsYXJlCit0aGUg cHJlIGFuZCBwb3N0IGNvbmRpdGlvbnMgdGhhdCB5b3VyIGNvZGUgc2hvdWxkIHNhdGlzZnksIHdo aWxlIGFsc28KK3Byb2R1Y2luZyBmcmllbmRseSBlcnJvciBtZXNzYWdlcyBzbyB0aGF0IHlvdXIg dXNlcnMga25vdyB3aGF0IHRoZXkndmUgZG9uZQord3JvbmcuIikKKyAgICAobGljZW5zZSBsaWNl bnNlOmdwbDMrKSkpCi0tIAoyLjUuMgoK --001a113b1954823034051fcc91d0--