From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 01/19] gnu: Add r-assertthat.
Date: Sun, 13 Sep 2015 22:04:47 +0200
Message-ID: <871te29jc0.fsf@elephly.net>
References: <CAMfbzvBt8NUDmEF=krz+Kx2k=vZ3GLEJF+VZ7v+pbzUPcDHsrg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33435)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZbDWS-00011B-ED
	for guix-devel@gnu.org; Sun, 13 Sep 2015 16:05:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZbDWP-0000uN-6C
	for guix-devel@gnu.org; Sun, 13 Sep 2015 16:05:12 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25663)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZbDWO-0000sS-V2
	for guix-devel@gnu.org; Sun, 13 Sep 2015 16:05:09 -0400
In-reply-to: <CAMfbzvBt8NUDmEF=krz+Kx2k=vZ3GLEJF+VZ7v+pbzUPcDHsrg@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Vicente Vera <vicentemvp@gmail.com>
Cc: guix-devel@gnu.org

Thank you very much for these patches!  Did you use the CRAN importer
for them?

You should add your name to the copyright header at the top of the file
(maybe as part of the first patch).

> * gnu/packages/statistics.scm (r-assertthat): New variable.

[...]

> +              (uri (string-append "mirror://cran/src/contrib/assertthat_"
> +                                  version ".tar.gz"))

I wonder if new patches should already contain the archive URI in
addition to the default URI.  It was pointed out in a previous thread
that the simple URI produced by the importer is only valid for the
latest version.

> +    (description
> +     "Assertthat is an extension to stopifnot() that makes it easy to
> +declare the pre and post conditions that you code should satisfy,

s/you code/your code/

> +while also producing friendly error messages so that your users know
> +what they've done wrong.")

~~ Ricardo