From: Vicente Vera <vicentemvp@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 01/19] gnu: Add r-assertthat.
Date: Tue, 15 Sep 2015 14:32:38 -0300 [thread overview]
Message-ID: <CAMfbzvAYYuTwYxg38t5-8hANdbwEEHqKZyrxhdhq1VE0X8bNmw@mail.gmail.com> (raw)
In-Reply-To: <CAMfbzvAKL-ZzV30ewf-+0E3c0SygLorbve89nKeaYuhM+ayOLg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]
Updated patch attached.
2015-09-13 19:20 GMT-03:00 Vicente Vera <vicentemvp@gmail.com>:
> Hi Ricardo,
>
> CRAN importer? Hmm, just made a very useful discovery! I feel ashamed now.
>
> Attached goes the 1st patch with the modified copyright header and the
> fixed typo (actually, it came with the package description in CRAN).
>
>
> 2015-09-13 17:04 GMT-03:00 Ricardo Wurmus <rekado@elephly.net>:
>> Thank you very much for these patches! Did you use the CRAN importer
>> for them?
>>
>> You should add your name to the copyright header at the top of the file
>> (maybe as part of the first patch).
>>
>>> * gnu/packages/statistics.scm (r-assertthat): New variable.
>>
>> [...]
>>
>>> + (uri (string-append "mirror://cran/src/contrib/assertthat_"
>>> + version ".tar.gz"))
>>
>> I wonder if new patches should already contain the archive URI in
>> addition to the default URI. It was pointed out in a previous thread
>> that the simple URI produced by the importer is only valid for the
>> latest version.
>>
>>> + (description
>>> + "Assertthat is an extension to stopifnot() that makes it easy to
>>> +declare the pre and post conditions that you code should satisfy,
>>
>> s/you code/your code/
>>
>>> +while also producing friendly error messages so that your users know
>>> +what they've done wrong.")
>>
>> ~~ Ricardo
>>
[-- Attachment #2: 0001-gnu-Add-r-assertthat.patch --]
[-- Type: text/x-patch, Size: 1848 bytes --]
From 466728d373cb114b6d36ca3b373cd019a3e57a4d Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Tue, 15 Sep 2015 14:11:12 -0300
Subject: [PATCH 01/19] gnu: Add r-assertthat.
* gnu/packages/statistics.scm (r-assertthat): New variable.
---
gnu/packages/statistics.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 29cd34a..9a73a82 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2015 Vicente Vera Parra <vicentemvp@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -498,3 +499,26 @@ by step from multiple data sources. It also implements a sophisticated
multidimensional conditioning system and a consistent interface to map data to
aesthetic attributes.")
(license license:gpl2+)))
+
+(define-public r-assertthat
+ (package
+ (name "r-assertthat")
+ (version "0.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://cran/src/contrib/assertthat_"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "0dwsqajyglfscqilj843qfqn1ndbqpswa7b4l1d633qjk9d68qqk"))))
+ (build-system r-build-system)
+ (home-page
+ "https://github.com/hadley/assertthat")
+ (synopsis
+ "Easy pre and post assertions")
+ (description
+ "Assertthat is an extension to stopifnot() that makes it easy to declare
+the pre and post conditions that your code should satisfy, while also
+producing friendly error messages so that your users know what they've done
+wrong.")
+ (license license:gpl3+)))
--
2.5.2
next prev parent reply other threads:[~2015-09-15 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:43 [PATCH 01/19] gnu: Add r-assertthat Vicente Vera
2015-09-13 20:04 ` Ricardo Wurmus
2015-09-13 20:08 ` Thompson, David
2015-09-13 20:25 ` Ricardo Wurmus
2015-09-13 22:20 ` Vicente Vera
2015-09-15 17:32 ` Vicente Vera [this message]
2015-09-15 19:10 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMfbzvAYYuTwYxg38t5-8hANdbwEEHqKZyrxhdhq1VE0X8bNmw@mail.gmail.com \
--to=vicentemvp@gmail.com \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).