unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Vicente Vera <vicentemvp@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 01/19] gnu: Add r-assertthat.
Date: Sun, 13 Sep 2015 22:04:47 +0200	[thread overview]
Message-ID: <871te29jc0.fsf@elephly.net> (raw)
In-Reply-To: <CAMfbzvBt8NUDmEF=krz+Kx2k=vZ3GLEJF+VZ7v+pbzUPcDHsrg@mail.gmail.com>

Thank you very much for these patches!  Did you use the CRAN importer
for them?

You should add your name to the copyright header at the top of the file
(maybe as part of the first patch).

> * gnu/packages/statistics.scm (r-assertthat): New variable.

[...]

> +              (uri (string-append "mirror://cran/src/contrib/assertthat_"
> +                                  version ".tar.gz"))

I wonder if new patches should already contain the archive URI in
addition to the default URI.  It was pointed out in a previous thread
that the simple URI produced by the importer is only valid for the
latest version.

> +    (description
> +     "Assertthat is an extension to stopifnot() that makes it easy to
> +declare the pre and post conditions that you code should satisfy,

s/you code/your code/

> +while also producing friendly error messages so that your users know
> +what they've done wrong.")

~~ Ricardo

  reply	other threads:[~2015-09-13 20:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 16:43 [PATCH 01/19] gnu: Add r-assertthat Vicente Vera
2015-09-13 20:04 ` Ricardo Wurmus [this message]
2015-09-13 20:08   ` Thompson, David
2015-09-13 20:25     ` Ricardo Wurmus
2015-09-13 22:20   ` Vicente Vera
2015-09-15 17:32     ` Vicente Vera
2015-09-15 19:10       ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871te29jc0.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=vicentemvp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).