Re: 01/01: gnu: php: Disable failing tests on armhf.

Re: 01/01: gnu: php: Disable failing tests on armhf.

[Ludovic Courtès]

Hello!

guix-commits@gnu.org skribis:

> commit e8cfce439afed945e352ad28f73f0a5f7840f503
> Author: Julien Lepiller <julien@lepiller.eu>
> Date:   Thu Mar 28 22:55:17 2019 +0100
>
>     gnu: php: Disable failing tests on armhf.
>     
>     * gnu/packages/php.scm (php)[arguments]: Disable failing tests on armhf.

[...]

> +             ,@(if (string-prefix? "armhf" (or (%current-system)
> +                                               (%current-target-system)))
> +                   ;; Drop tests known to fail on armhf.
> +                   '((for-each delete-file
> +                              (list
> +                                "ext/calendar/tests/unixtojd_error1.phpt"
> +                                ;; arm can be a lot slower, so a time-related test fails
> +                                "ext/fileinfo/tests/cve-2014-3538-nojit.phpt"
> +                                "ext/pcre/tests/bug76514.phpt"
> +                                "ext/pcre/tests/preg_match_error3.phpt"))))

I think the ‘else’ branch is missing, which presumably breaks PHP on
non-ARM platforms.

Also, ‘%current-target-system’ is a GNU triplet, typically
“arm-linux-gnueabihf”, which doesn’t start with “armhf”.  I think the
test should be (string-prefix? "arm" …).

Thanks,
Ludo’.

Re: 01/01: gnu: php: Disable failing tests on armhf.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 2467 bytes --]


guix-commits@gnu.org writes:

> roptat pushed a commit to branch master
> in repository guix.
>
> commit e8cfce439afed945e352ad28f73f0a5f7840f503
> Author: Julien Lepiller <julien@lepiller.eu>
> Date:   Thu Mar 28 22:55:17 2019 +0100
>
>     gnu: php: Disable failing tests on armhf.
>
>     * gnu/packages/php.scm (php)[arguments]: Disable failing tests on armhf.
> ---
>  gnu/packages/php.scm | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
> index 8d96e54..ffb81da 100644
> --- a/gnu/packages/php.scm
> +++ b/gnu/packages/php.scm
> @@ -86,7 +86,7 @@
>                    #t))))
>      (build-system gnu-build-system)
>      (arguments
> -     '(#:configure-flags
> +     `(#:configure-flags
>         (let-syntax ((with (syntax-rules ()
>                              ((_ option input)
>                               (string-append option "="
> @@ -182,6 +182,17 @@
>               (substitute* "ext/standard/tests/streams/bug60602.phpt"
>                 (("'ls'") (string-append "'" (which "ls") "'")))
>
> +             ,@(if (string-prefix? "armhf" (or (%current-system)
> +                                               (%current-target-system)))
> +                   ;; Drop tests known to fail on armhf.
> +                   '((for-each delete-file
> +                              (list
> +                                "ext/calendar/tests/unixtojd_error1.phpt"
> +                                ;; arm can be a lot slower, so a time-related test fails
> +                                "ext/fileinfo/tests/cve-2014-3538-nojit.phpt"
> +                                "ext/pcre/tests/bug76514.phpt"
> +                                "ext/pcre/tests/preg_match_error3.phpt"))))
> +
>               ;; Drop tests that are known to fail.
>               (for-each delete-file
>                         '("ext/posix/tests/posix_getgrgid.phpt"    ; Requires /etc/group.

Hey,

I think I might be encountering an issue with this change. When running
package-transitive-supported-systems on php, I get the following error.

In procedure append: Wrong type argument in position 1 (expecting empty list): #<unspecified>

My guess is that the #<unspecified> in the error is coming from the 2nd,
unspecified branch of the if statement introduced here.

I'm also not quite sure what the condition of the if will do, when will
(%current-system) not be present?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: 01/01: gnu: php: Disable failing tests on armhf.

[Julien Lepiller]

Le 29 mars 2019 09:35:13 GMT+01:00, Christopher Baines <mail@cbaines.net> a écrit :
>
>guix-commits@gnu.org writes:
>
>> roptat pushed a commit to branch master
>> in repository guix.
>>
>> commit e8cfce439afed945e352ad28f73f0a5f7840f503
>> Author: Julien Lepiller <julien@lepiller.eu>
>> Date:   Thu Mar 28 22:55:17 2019 +0100
>>
>>     gnu: php: Disable failing tests on armhf.
>>
>>     * gnu/packages/php.scm (php)[arguments]: Disable failing tests on
>armhf.
>> ---
>>  gnu/packages/php.scm | 13 ++++++++++++-
>>  1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
>> index 8d96e54..ffb81da 100644
>> --- a/gnu/packages/php.scm
>> +++ b/gnu/packages/php.scm
>> @@ -86,7 +86,7 @@
>>                    #t))))
>>      (build-system gnu-build-system)
>>      (arguments
>> -     '(#:configure-flags
>> +     `(#:configure-flags
>>         (let-syntax ((with (syntax-rules ()
>>                              ((_ option input)
>>                               (string-append option "="
>> @@ -182,6 +182,17 @@
>>               (substitute* "ext/standard/tests/streams/bug60602.phpt"
>>                 (("'ls'") (string-append "'" (which "ls") "'")))
>>
>> +             ,@(if (string-prefix? "armhf" (or (%current-system)
>> +                                              
>(%current-target-system)))
>> +                   ;; Drop tests known to fail on armhf.
>> +                   '((for-each delete-file
>> +                              (list
>> +                               
>"ext/calendar/tests/unixtojd_error1.phpt"
>> +                                ;; arm can be a lot slower, so a
>time-related test fails
>> +                               
>"ext/fileinfo/tests/cve-2014-3538-nojit.phpt"
>> +                                "ext/pcre/tests/bug76514.phpt"
>> +                               
>"ext/pcre/tests/preg_match_error3.phpt"))))
>> +
>>               ;; Drop tests that are known to fail.
>>               (for-each delete-file
>>                         '("ext/posix/tests/posix_getgrgid.phpt"    ;
>Requires /etc/group.
>
>Hey,
>
>I think I might be encountering an issue with this change. When running
>package-transitive-supported-systems on php, I get the following error.
>
>In procedure append: Wrong type argument in position 1 (expecting empty
>list): #<unspecified>
>
>My guess is that the #<unspecified> in the error is coming from the
>2nd,
>unspecified branch of the if statement introduced here.
>
>I'm also not quite sure what the condition of the if will do, when will
>(%current-system) not be present?
>
>Thanks,
>
>Chris

Sorry about that :/

I won't be able to push a fix in the next 10 hours or so, so if someone wants to do something before then, please do :)

I took the if statement from classpath-jamvm-wrappers in java.scm.

Re: 01/01: gnu: php: Disable failing tests on armhf.

[Ludovic Courtès]

Julien Lepiller <julien@lepiller.eu> skribis:

> I won't be able to push a fix in the next 10 hours or so, so if someone wants to do something before then, please do :)

Pushed as 9398152ad1f4e130ad895c8bb756de8a33e91f7f!

Ludo’.