From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Lepiller Subject: Re: 01/01: gnu: php: Disable failing tests on armhf. Date: Fri, 29 Mar 2019 10:18:46 +0100 Message-ID: <96407862-1710-424C-A8F4-D5D8B179D340@lepiller.eu> References: <20190328215944.26750.66794@vcs0.savannah.gnu.org> <20190328215945.3F18020619@vcs0.savannah.gnu.org> <87imw2jcxq.fsf@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:54304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9nf6-0007n6-Rv for guix-devel@gnu.org; Fri, 29 Mar 2019 05:18:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9nf5-0000pm-RE for guix-devel@gnu.org; Fri, 29 Mar 2019 05:18:56 -0400 Received: from lepiller.eu ([89.234.186.109]:39202) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h9nf5-0000mA-El for guix-devel@gnu.org; Fri, 29 Mar 2019 05:18:55 -0400 In-Reply-To: <87imw2jcxq.fsf@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel@gnu.org Le 29 mars 2019 09:35:13 GMT+01:00, Christopher Baines = a =C3=A9crit : > >guix-commits@gnu=2Eorg writes: > >> roptat pushed a commit to branch master >> in repository guix=2E >> >> commit e8cfce439afed945e352ad28f73f0a5f7840f503 >> Author: Julien Lepiller >> Date: Thu Mar 28 22:55:17 2019 +0100 >> >> gnu: php: Disable failing tests on armhf=2E >> >> * gnu/packages/php=2Escm (php)[arguments]: Disable failing tests on >armhf=2E >> --- >> gnu/packages/php=2Escm | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/php=2Escm b/gnu/packages/php=2Escm >> index 8d96e54=2E=2Effb81da 100644 >> --- a/gnu/packages/php=2Escm >> +++ b/gnu/packages/php=2Escm >> @@ -86,7 +86,7 @@ >> #t)))) >> (build-system gnu-build-system) >> (arguments >> - '(#:configure-flags >> + `(#:configure-flags >> (let-syntax ((with (syntax-rules () >> ((_ option input) >> (string-append option "=3D" >> @@ -182,6 +182,17 @@ >> (substitute* "ext/standard/tests/streams/bug60602=2Ephpt" >> (("'ls'") (string-append "'" (which "ls") "'"))) >> >> + ,@(if (string-prefix? "armhf" (or (%current-system) >> + =20 >(%current-target-system))) >> + ;; Drop tests known to fail on armhf=2E >> + '((for-each delete-file >> + (list >> + =20 >"ext/calendar/tests/unixtojd_error1=2Ephpt" >> + ;; arm can be a lot slower, so a >time-related test fails >> + =20 >"ext/fileinfo/tests/cve-2014-3538-nojit=2Ephpt" >> + "ext/pcre/tests/bug76514=2Ephpt" >> + =20 >"ext/pcre/tests/preg_match_error3=2Ephpt")))) >> + >> ;; Drop tests that are known to fail=2E >> (for-each delete-file >> '("ext/posix/tests/posix_getgrgid=2Ephpt" ; >Requires /etc/group=2E > >Hey, > >I think I might be encountering an issue with this change=2E When running >package-transitive-supported-systems on php, I get the following error=2E > >In procedure append: Wrong type argument in position 1 (expecting empty >list): # > >My guess is that the # in the error is coming from the >2nd, >unspecified branch of the if statement introduced here=2E > >I'm also not quite sure what the condition of the if will do, when will >(%current-system) not be present? > >Thanks, > >Chris Sorry about that :/ I won't be able to push a fix in the next 10 hours or so, so if someone wa= nts to do something before then, please do :) I took the if statement from classpath-jamvm-wrappers in java=2Escm=2E