From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 01/01: gnu: php: Disable failing tests on armhf.
Date: Fri, 29 Mar 2019 09:25:48 +0100
Message-ID: <87woki9jeb.fsf@gnu.org>
References: <20190328215944.26750.66794@vcs0.savannah.gnu.org>
	<20190328215945.3F18020619@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:43654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1h9mpo-0007Gc-VL
	for guix-devel@gnu.org; Fri, 29 Mar 2019 04:25:58 -0400
In-Reply-To: <20190328215945.3F18020619@vcs0.savannah.gnu.org> (guix-commits's
	message of "Thu, 28 Mar 2019 17:59:45 -0400 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, julien@lepiller.eu

Hello!

guix-commits@gnu.org skribis:

> commit e8cfce439afed945e352ad28f73f0a5f7840f503
> Author: Julien Lepiller <julien@lepiller.eu>
> Date:   Thu Mar 28 22:55:17 2019 +0100
>
>     gnu: php: Disable failing tests on armhf.
>=20=20=20=20=20
>     * gnu/packages/php.scm (php)[arguments]: Disable failing tests on arm=
hf.

[...]

> +             ,@(if (string-prefix? "armhf" (or (%current-system)
> +                                               (%current-target-system)))
> +                   ;; Drop tests known to fail on armhf.
> +                   '((for-each delete-file
> +                              (list
> +                                "ext/calendar/tests/unixtojd_error1.phpt"
> +                                ;; arm can be a lot slower, so a time-re=
lated test fails
> +                                "ext/fileinfo/tests/cve-2014-3538-nojit.=
phpt"
> +                                "ext/pcre/tests/bug76514.phpt"
> +                                "ext/pcre/tests/preg_match_error3.phpt")=
)))

I think the =E2=80=98else=E2=80=99 branch is missing, which presumably brea=
ks PHP on
non-ARM platforms.

Also, =E2=80=98%current-target-system=E2=80=99 is a GNU triplet, typically
=E2=80=9Carm-linux-gnueabihf=E2=80=9D, which doesn=E2=80=99t start with =E2=
=80=9Carmhf=E2=80=9D.  I think the
test should be (string-prefix? "arm" =E2=80=A6).

Thanks,
Ludo=E2=80=99.