* Re: 01/01: gnu: php: Disable failing tests on armhf. [not found] ` <20190328215945.3F18020619@vcs0.savannah.gnu.org> @ 2019-03-29 8:25 ` Ludovic Courtès 2019-03-29 8:35 ` Christopher Baines 1 sibling, 0 replies; 4+ messages in thread From: Ludovic Courtès @ 2019-03-29 8:25 UTC (permalink / raw) To: guix-devel, julien Hello! guix-commits@gnu.org skribis: > commit e8cfce439afed945e352ad28f73f0a5f7840f503 > Author: Julien Lepiller <julien@lepiller.eu> > Date: Thu Mar 28 22:55:17 2019 +0100 > > gnu: php: Disable failing tests on armhf. > > * gnu/packages/php.scm (php)[arguments]: Disable failing tests on armhf. [...] > + ,@(if (string-prefix? "armhf" (or (%current-system) > + (%current-target-system))) > + ;; Drop tests known to fail on armhf. > + '((for-each delete-file > + (list > + "ext/calendar/tests/unixtojd_error1.phpt" > + ;; arm can be a lot slower, so a time-related test fails > + "ext/fileinfo/tests/cve-2014-3538-nojit.phpt" > + "ext/pcre/tests/bug76514.phpt" > + "ext/pcre/tests/preg_match_error3.phpt")))) I think the ‘else’ branch is missing, which presumably breaks PHP on non-ARM platforms. Also, ‘%current-target-system’ is a GNU triplet, typically “arm-linux-gnueabihf”, which doesn’t start with “armhf”. I think the test should be (string-prefix? "arm" …). Thanks, Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: php: Disable failing tests on armhf. [not found] ` <20190328215945.3F18020619@vcs0.savannah.gnu.org> 2019-03-29 8:25 ` 01/01: gnu: php: Disable failing tests on armhf Ludovic Courtès @ 2019-03-29 8:35 ` Christopher Baines 2019-03-29 9:18 ` Julien Lepiller 1 sibling, 1 reply; 4+ messages in thread From: Christopher Baines @ 2019-03-29 8:35 UTC (permalink / raw) To: Julien Lepiller; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 2467 bytes --] guix-commits@gnu.org writes: > roptat pushed a commit to branch master > in repository guix. > > commit e8cfce439afed945e352ad28f73f0a5f7840f503 > Author: Julien Lepiller <julien@lepiller.eu> > Date: Thu Mar 28 22:55:17 2019 +0100 > > gnu: php: Disable failing tests on armhf. > > * gnu/packages/php.scm (php)[arguments]: Disable failing tests on armhf. > --- > gnu/packages/php.scm | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm > index 8d96e54..ffb81da 100644 > --- a/gnu/packages/php.scm > +++ b/gnu/packages/php.scm > @@ -86,7 +86,7 @@ > #t)))) > (build-system gnu-build-system) > (arguments > - '(#:configure-flags > + `(#:configure-flags > (let-syntax ((with (syntax-rules () > ((_ option input) > (string-append option "=" > @@ -182,6 +182,17 @@ > (substitute* "ext/standard/tests/streams/bug60602.phpt" > (("'ls'") (string-append "'" (which "ls") "'"))) > > + ,@(if (string-prefix? "armhf" (or (%current-system) > + (%current-target-system))) > + ;; Drop tests known to fail on armhf. > + '((for-each delete-file > + (list > + "ext/calendar/tests/unixtojd_error1.phpt" > + ;; arm can be a lot slower, so a time-related test fails > + "ext/fileinfo/tests/cve-2014-3538-nojit.phpt" > + "ext/pcre/tests/bug76514.phpt" > + "ext/pcre/tests/preg_match_error3.phpt")))) > + > ;; Drop tests that are known to fail. > (for-each delete-file > '("ext/posix/tests/posix_getgrgid.phpt" ; Requires /etc/group. Hey, I think I might be encountering an issue with this change. When running package-transitive-supported-systems on php, I get the following error. In procedure append: Wrong type argument in position 1 (expecting empty list): #<unspecified> My guess is that the #<unspecified> in the error is coming from the 2nd, unspecified branch of the if statement introduced here. I'm also not quite sure what the condition of the if will do, when will (%current-system) not be present? Thanks, Chris [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 962 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: php: Disable failing tests on armhf. 2019-03-29 8:35 ` Christopher Baines @ 2019-03-29 9:18 ` Julien Lepiller 2019-03-29 16:03 ` Ludovic Courtès 0 siblings, 1 reply; 4+ messages in thread From: Julien Lepiller @ 2019-03-29 9:18 UTC (permalink / raw) To: Christopher Baines; +Cc: guix-devel Le 29 mars 2019 09:35:13 GMT+01:00, Christopher Baines <mail@cbaines.net> a écrit : > >guix-commits@gnu.org writes: > >> roptat pushed a commit to branch master >> in repository guix. >> >> commit e8cfce439afed945e352ad28f73f0a5f7840f503 >> Author: Julien Lepiller <julien@lepiller.eu> >> Date: Thu Mar 28 22:55:17 2019 +0100 >> >> gnu: php: Disable failing tests on armhf. >> >> * gnu/packages/php.scm (php)[arguments]: Disable failing tests on >armhf. >> --- >> gnu/packages/php.scm | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm >> index 8d96e54..ffb81da 100644 >> --- a/gnu/packages/php.scm >> +++ b/gnu/packages/php.scm >> @@ -86,7 +86,7 @@ >> #t)))) >> (build-system gnu-build-system) >> (arguments >> - '(#:configure-flags >> + `(#:configure-flags >> (let-syntax ((with (syntax-rules () >> ((_ option input) >> (string-append option "=" >> @@ -182,6 +182,17 @@ >> (substitute* "ext/standard/tests/streams/bug60602.phpt" >> (("'ls'") (string-append "'" (which "ls") "'"))) >> >> + ,@(if (string-prefix? "armhf" (or (%current-system) >> + >(%current-target-system))) >> + ;; Drop tests known to fail on armhf. >> + '((for-each delete-file >> + (list >> + >"ext/calendar/tests/unixtojd_error1.phpt" >> + ;; arm can be a lot slower, so a >time-related test fails >> + >"ext/fileinfo/tests/cve-2014-3538-nojit.phpt" >> + "ext/pcre/tests/bug76514.phpt" >> + >"ext/pcre/tests/preg_match_error3.phpt")))) >> + >> ;; Drop tests that are known to fail. >> (for-each delete-file >> '("ext/posix/tests/posix_getgrgid.phpt" ; >Requires /etc/group. > >Hey, > >I think I might be encountering an issue with this change. When running >package-transitive-supported-systems on php, I get the following error. > >In procedure append: Wrong type argument in position 1 (expecting empty >list): #<unspecified> > >My guess is that the #<unspecified> in the error is coming from the >2nd, >unspecified branch of the if statement introduced here. > >I'm also not quite sure what the condition of the if will do, when will >(%current-system) not be present? > >Thanks, > >Chris Sorry about that :/ I won't be able to push a fix in the next 10 hours or so, so if someone wants to do something before then, please do :) I took the if statement from classpath-jamvm-wrappers in java.scm. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: php: Disable failing tests on armhf. 2019-03-29 9:18 ` Julien Lepiller @ 2019-03-29 16:03 ` Ludovic Courtès 0 siblings, 0 replies; 4+ messages in thread From: Ludovic Courtès @ 2019-03-29 16:03 UTC (permalink / raw) To: Julien Lepiller; +Cc: guix-devel Julien Lepiller <julien@lepiller.eu> skribis: > I won't be able to push a fix in the next 10 hours or so, so if someone wants to do something before then, please do :) Pushed as 9398152ad1f4e130ad895c8bb756de8a33e91f7f! Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-29 16:03 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20190328215944.26750.66794@vcs0.savannah.gnu.org> [not found] ` <20190328215945.3F18020619@vcs0.savannah.gnu.org> 2019-03-29 8:25 ` 01/01: gnu: php: Disable failing tests on armhf Ludovic Courtès 2019-03-29 8:35 ` Christopher Baines 2019-03-29 9:18 ` Julien Lepiller 2019-03-29 16:03 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).