From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: 01/01: gnu: php: Disable failing tests on armhf. Date: Fri, 29 Mar 2019 08:35:13 +0000 Message-ID: <87imw2jcxq.fsf@cbaines.net> References: <20190328215944.26750.66794@vcs0.savannah.gnu.org> <20190328215945.3F18020619@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:45186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9mz1-0000x0-A0 for guix-devel@gnu.org; Fri, 29 Mar 2019 04:35:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9myz-0007h1-DS for guix-devel@gnu.org; Fri, 29 Mar 2019 04:35:27 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:60882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9myu-0007dJ-74 for guix-devel@gnu.org; Fri, 29 Mar 2019 04:35:23 -0400 In-reply-to: <20190328215945.3F18020619@vcs0.savannah.gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Julien Lepiller Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain guix-commits@gnu.org writes: > roptat pushed a commit to branch master > in repository guix. > > commit e8cfce439afed945e352ad28f73f0a5f7840f503 > Author: Julien Lepiller > Date: Thu Mar 28 22:55:17 2019 +0100 > > gnu: php: Disable failing tests on armhf. > > * gnu/packages/php.scm (php)[arguments]: Disable failing tests on armhf. > --- > gnu/packages/php.scm | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm > index 8d96e54..ffb81da 100644 > --- a/gnu/packages/php.scm > +++ b/gnu/packages/php.scm > @@ -86,7 +86,7 @@ > #t)))) > (build-system gnu-build-system) > (arguments > - '(#:configure-flags > + `(#:configure-flags > (let-syntax ((with (syntax-rules () > ((_ option input) > (string-append option "=" > @@ -182,6 +182,17 @@ > (substitute* "ext/standard/tests/streams/bug60602.phpt" > (("'ls'") (string-append "'" (which "ls") "'"))) > > + ,@(if (string-prefix? "armhf" (or (%current-system) > + (%current-target-system))) > + ;; Drop tests known to fail on armhf. > + '((for-each delete-file > + (list > + "ext/calendar/tests/unixtojd_error1.phpt" > + ;; arm can be a lot slower, so a time-related test fails > + "ext/fileinfo/tests/cve-2014-3538-nojit.phpt" > + "ext/pcre/tests/bug76514.phpt" > + "ext/pcre/tests/preg_match_error3.phpt")))) > + > ;; Drop tests that are known to fail. > (for-each delete-file > '("ext/posix/tests/posix_getgrgid.phpt" ; Requires /etc/group. Hey, I think I might be encountering an issue with this change. When running package-transitive-supported-systems on php, I get the following error. In procedure append: Wrong type argument in position 1 (expecting empty list): # My guess is that the # in the error is coming from the 2nd, unspecified branch of the if statement introduced here. I'm also not quite sure what the condition of the if will do, when will (%current-system) not be present? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlyd2MFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XftExAAk5I1JWO5NuuCFixo1wWdlmynLJFTp7XCST887Qm76bTZIqolJS9qqN28 MhhW7zMt1+9am5927ME+B+lFmil2M2D05JBxCEyLXPsJKwu63dUu8/ro1eonqy9k XcldNTH005CDXxfwKCVnb7Pa3RmLq1yoG4kY/4v4GClxJtx8u774wTcONlQeY/Fv s3ymLWDpM6L7IRcAlL6hl0Quc3IJwXQJKkbHJMDxE0yJjoxT01ck4HsIJuuV1shn EG69sjgcKZ8QWR1RmUYqP3Wk037uOucVE1vd9BMVM0zjSVq6AKP6Tau/1R1Lnlpj VDLfe1f/dndAJuRU+1vBzNxpfobYwMLlcOZhs/7P/gIFzc632Hnn2OsnOY1BQHUy HHFgwo9nf54B5txl/Bn9a5DeyTefoQvFAYqSblKKjk7I4mXhQm1neYsgJ7duiTts yakUGOxwWRX5Z6ktFzDhB+RuOUTmOCUv3gl5CLsbnFOBAC78K46hoGNiVADVfgbz e2VRT6p9q+a1r5Jskm/KoIPz+qo4M3YbaykQbSJIU6bHoT6hDaaVPxiX26+ZTuKT Wjgmr9pDLJPFAFXlWRWG+dBNAc21gyIDwvyPcDs4MqX8vxG2kEk2x5ApO0H926vy uli475MN86h77yas+qCnzh/Oy4+s8im/ozFV6WM9WNIjYUDEvTA= =adQH -----END PGP SIGNATURE----- --=-=-=--