From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: [PATCH] gnu: Add cool-retro-term. Date: Sun, 23 Apr 2017 12:18:05 -0700 Message-ID: <87inlvhr0y.fsf@gmail.com> References: <20170423135526.5ed9d143@mykolab.ch> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2N1R-0001yh-9g for guix-devel@gnu.org; Sun, 23 Apr 2017 15:18:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2N1Q-0001jf-BR for guix-devel@gnu.org; Sun, 23 Apr 2017 15:18:13 -0400 Received: from mail-it0-x22c.google.com ([2607:f8b0:4001:c0b::22c]:34098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2N1Q-0001jY-5g for guix-devel@gnu.org; Sun, 23 Apr 2017 15:18:12 -0400 Received: by mail-it0-x22c.google.com with SMTP id b134so2452030iti.1 for ; Sun, 23 Apr 2017 12:18:12 -0700 (PDT) In-Reply-To: <20170423135526.5ed9d143@mykolab.ch> (petter@mykolab.ch's message of "Sun, 23 Apr 2017 13:55:26 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Petter Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Petter writes: > Hi Guix, > > The past is finally here! Had a go at packaging a terminal emulator > which mimics old cathode displays :) Wow!! This is really fun. Thanks for packaging it! > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (substitute* '("qmltermwidget/qmltermwidget.pro") > + (("INSTALL_DIR =3D \\$\\$\\[QT_INSTALL_QML\\]") > + (string-append "INSTALL_DIR =3D " out "/qml"))) > + (substitute* '("app/app.pro") > + (("target.path \\+=3D /usr") > + (string-append "target.path +=3D " out)) > + (("icon32.path =3D /usr/share") > + (string-append "icon32.path =3D " out)) > + (("icon64.path =3D /usr/share") > + (string-append "icon64.path =3D " out)) > + (("icon128.path =3D /usr/share") > + (string-append "icon128.path =3D " out)) > + (("icon256.path =3D /usr/share") > + (string-append "icon256.path =3D " out))) > + (zero? (system* "qmake"))))) Should these icons be put somewhere else, like in the $out/share path? If it works, it works, though. (info '(standards) Directory Variables'): > + (synopsis "terminal emulator which mimics the look and feel of the o= ld > +cathode tube screens") > + (description > + "Cool-retro-term is a terminal emulator which mimics the look and f= eel of > +the old cathode tube screens. It has been designed to be eye-candy, > +customizable, and reasonably lightweight.") Just minor feedback: Maybe use the phrases "CRT" and "cathode ray tube" to make this easier to discover? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlj8/e0ACgkQ3UCaFdgi Rp19OBAAvAB/axkmHxeOgNN9pgjZ2b1qbDDfackS4fa3dLtsOdhlSkfkoZ1wiGlD Ccnr47tVRBsGqAGU3sc6vkgtWqnOEY4XZFL+6cI7IkUs7qx0Qu5UioSxY2NcW/eK yKQF/NZuKpbDh+OjGPFt/dBx/M95BtB2WuewgmpQCqEqMSggvcZ4GnltubvhZjbo x2/KJJZx5WWAXoqvyc+FgUALITbqdPH37ATqV5LsnoQMIVGN/b4MZyGGlexZmtDc Aww9bowErOz/CTJtegAKxK5G+yk5MAN1RtWLgw5VyEP2jE0BfosK38d6XYaUhYqU 85/OLTaEPStRqd6H3bZzsCg8iejE0ZA/sVFu2Y8HCKR8X1+Vy61d9d0WjBbeEjc0 2RtAZmDxbOiZw8wSDjye3yAYi+OxSDnZC1pHXzMe7NQAo+wGa/jo7awVKMjdf9Z+ BdwLDD0fiz4hL3AXkaNljOq9UQ+Ilul5n1LiSfP6ix+UeSJ+WIdMRGXY1OE7+Iud xFf811owaj9taYxpKBPhyImWRWy8GiSfegf6HHOeXlGj8VjpYWU3uHOn60H3LLMh lVvbkoCGVPNNf/mhDuySvLCcLkM8bxep+QtkoVKRD14BJHlQajL2lWUjPkckP6+I mcE3pbvH/XDy+F3e/wKC3pekoOUEXYnsefyFjPIDaJTgItCXfGY= =ZhB+ -----END PGP SIGNATURE----- --=-=-=--