Ruby 2.5, pushing to staging?

Ruby 2.5, pushing to staging?

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Hey,

A new minor version of Ruby has been out for a while, and it would be
good to get Ruby 2.5 in to Guix.

I've put up a patch here [1], and tried it locally. I've pushed some
fixes to master to make some packages compatible [2], and while I do get
some failures when building the 958 (according to guix refresh -l)
dependant packages, I'm unsure how many of these are down to the Ruby
upgrade.

1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32871
2: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32870

Anyway, looking at the contributing guide this is possibly too big of a
change to push directly to master, so should I push this to the staging
branch?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: Ruby 2.5, pushing to staging? [UNSCANNED]

[Benjamin Woodcroft]

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

Hi Chris,


Thanks for pushing this forward. When I tried with 2.5.0, timestamps meant that the build was not reproducible - just wanted to check that you'd considered this - sorry if that is noise.


Pushing it to staging is what was done previously.

Ta, ben

________________________________
From: Guix-devel <guix-devel-bounces+b.woodcroft=uq.edu.au@gnu.org> on behalf of Christopher Baines <mail@cbaines.net>
Sent: Saturday, 6 October 2018 8:59:17 AM
To: guix-devel@gnu.org
Subject: Ruby 2.5, pushing to staging? [UNSCANNED]

Hey,

A new minor version of Ruby has been out for a while, and it would be
good to get Ruby 2.5 in to Guix.

I've put up a patch here [1], and tried it locally. I've pushed some
fixes to master to make some packages compatible [2], and while I do get
some failures when building the 958 (according to guix refresh -l)
dependant packages, I'm unsure how many of these are down to the Ruby
upgrade.

1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32871
2: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32870

Anyway, looking at the contributing guide this is possibly too big of a
change to push directly to master, so should I push this to the staging
branch?

Thanks,

Chris

[-- Attachment #2: Type: text/html, Size: 2441 bytes --]

Re: Ruby 2.5, pushing to staging? [UNSCANNED]

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]


Benjamin Woodcroft <b.woodcroft@uq.edu.au> writes:

> Hi Chris,
>
> Thanks for pushing this forward. When I tried with 2.5.0, timestamps meant that the build was not reproducible - just wanted to check that you'd considered this - sorry if that is noise.

Thanks for the information Ben, I haven't considered
reproducibility. How did you check the 2.5.0 package?

I've tried builing locally with the following command, and I get
something that suggests there may be a problem, but I'm not sure where
to go from here.

$ ./pre-inst-env guix build --no-grafts --rounds=2 --check ruby

guix build: error: build failed: derivation `/gnu/store/37rb11ivy4w6ydn0px386k158ixbgczz-ruby-2.5.1.drv' may not be deterministic

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: Ruby 2.5, pushing to staging? [UNSCANNED]

[Benjamin Woodcroft]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

> I've tried builing locally with the following command, and I get
something that suggests there may be a problem, but I'm not sure where
to go from here.
>
> $ ./pre-inst-env guix build --no-grafts --rounds=2 --check ruby
>
> guix build: error: build failed: derivation `/gnu/store/37rb11ivy4w6ydn0px386k158ixbgczz-ruby-2.5.1.drv' may not be deterministic


Not sure if I am the best person to ask, but I generally build it once, copy the store directory to /tmp, delete it from the store with "gc", then build it again. Finally, compare the two directory trees - I use "meld" (don't think this is in Guix, unfortunately), but others use "diffoscope", as I understand.


HTH, ben

[-- Attachment #2: Type: text/html, Size: 1606 bytes --]

Re: Ruby 2.5, pushing to staging? [UNSCANNED]

[Ricardo Wurmus]

Christopher Baines <mail@cbaines.net> writes:

> I've tried builing locally with the following command, and I get
> something that suggests there may be a problem, but I'm not sure where
> to go from here.
>
> $ ./pre-inst-env guix build --no-grafts --rounds=2 --check ruby
>
> guix build: error: build failed: derivation `/gnu/store/37rb11ivy4w6ydn0px386k158ixbgczz-ruby-2.5.1.drv' may not be deterministic

You can add “-K” to keep the second build.  Then you can compare the two
directories with diffoscope.

(You only need “--check” if you already have a local build; “--rounds=2”
is for an initial build that should be performed twice.)

-- 
Ricardo

Re: Ruby 2.5, pushing to staging? [UNSCANNED]

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]


Ricardo Wurmus <rekado@elephly.net> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> I've tried builing locally with the following command, and I get
>> something that suggests there may be a problem, but I'm not sure where
>> to go from here.
>>
>> $ ./pre-inst-env guix build --no-grafts --rounds=2 --check ruby
>>
>> guix build: error: build failed: derivation `/gnu/store/37rb11ivy4w6ydn0px386k158ixbgczz-ruby-2.5.1.drv' may not be deterministic
>
> You can add “-K” to keep the second build.  Then you can compare the two
> directories with diffoscope.
>
> (You only need “--check” if you already have a local build; “--rounds=2”
> is for an initial build that should be performed twice.)

Thanks, this works really well. Comparing the two outputs with
diffoscope --exclude-command stat shows that there are some timestamp
issues, some with the ri documentation, and others with the gemspec's
for the bundled gems.

Taking the same approach for ruby 2.4, ruby 2.5 actually seems a lot
better. Ruby 2.4 seems to have some file ordering issues as well
(although maybe they just didn't crop up for my build of Ruby 2.5) as
well as some of the binary files differing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: Ruby 2.5, pushing to staging?

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> A new minor version of Ruby has been out for a while, and it would be
> good to get Ruby 2.5 in to Guix.
>
> I've put up a patch here [1], and tried it locally. I've pushed some
> fixes to master to make some packages compatible [2], and while I do get
> some failures when building the 958 (according to guix refresh -l)
> dependant packages, I'm unsure how many of these are down to the Ruby
> upgrade.
>
> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32871
> 2: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32870
>
> Anyway, looking at the contributing guide this is possibly too big of a
> change to push directly to master, so should I push this to the staging
> branch?

I've now gone ahead and pushed to staging. Not really sure what happens
now.... will berlin and hydra pick this up automatically, and start
building packages?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: [bug#32871] Ruby 2.5, pushing to staging?

[Ludovic Courtès]

Hi Chris,

Christopher Baines <mail@cbaines.net> skribis:

> Christopher Baines <mail@cbaines.net> writes:
>
>> A new minor version of Ruby has been out for a while, and it would be
>> good to get Ruby 2.5 in to Guix.
>>
>> I've put up a patch here [1], and tried it locally. I've pushed some
>> fixes to master to make some packages compatible [2], and while I do get
>> some failures when building the 958 (according to guix refresh -l)
>> dependant packages, I'm unsure how many of these are down to the Ruby
>> upgrade.
>>
>> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32871
>> 2: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32870
>>
>> Anyway, looking at the contributing guide this is possibly too big of a
>> change to push directly to master, so should I push this to the staging
>> branch?
>
> I've now gone ahead and pushed to staging. Not really sure what happens
> now.... will berlin and hydra pick this up automatically, and start
> building packages?

Not yet!  Primarily because we’re focusing (or trying to…) on building
core-updates so we can get it merged soonish, after which we can
hopefully merge staging.

Thanks!

Ludo’.

Re: [bug#32871] Ruby 2.5, pushing to staging?

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hi Chris,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Christopher Baines <mail@cbaines.net> writes:

...

>>> Anyway, looking at the contributing guide this is possibly too big of a
>>> change to push directly to master, so should I push this to the staging
>>> branch?
>>
>> I've now gone ahead and pushed to staging. Not really sure what happens
>> now.... will berlin and hydra pick this up automatically, and start
>> building packages?
>
> Not yet!  Primarily because we’re focusing (or trying to…) on building
> core-updates so we can get it merged soonish, after which we can
> hopefully merge staging.

So, berlin seemed to do something [1], but most of the builds are
scheduled. But yeah, waiting for core-updates is fine.

1: http://berlin.guixsd.org/eval/1072

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: Ruby 2.5, pushing to staging?

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> A new minor version of Ruby has been out for a while, and it would be
>> good to get Ruby 2.5 in to Guix.
>>
>> I've put up a patch here [1], and tried it locally. I've pushed some
>> fixes to master to make some packages compatible [2], and while I do get
>> some failures when building the 958 (according to guix refresh -l)
>> dependant packages, I'm unsure how many of these are down to the Ruby
>> upgrade.
>>
>> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32871
>> 2: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32870
>>
>> Anyway, looking at the contributing guide this is possibly too big of a
>> change to push directly to master, so should I push this to the staging
>> branch?
>
> I've now gone ahead and pushed to staging. Not really sure what happens
> now.... will berlin and hydra pick this up automatically, and start
> building packages?

So, I'm still interested in pushing Ruby 2.5 forward. I've now pushed an
upgrade from 2.5.1 to 2.5.3 to the staging branch, as that seemed
sensible.

I can see that ci.guix.info (berlin) has picked this up (I think here
[1]), but I'm not sure what to do next...?

Thanks,

Chris

1: http://ci.guix.info/eval/2010

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: Ruby 2.5, pushing to staging?

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

Christopher Baines <mail@cbaines.net> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> Christopher Baines <mail@cbaines.net> writes:
>>
>>> A new minor version of Ruby has been out for a while, and it would be
>>> good to get Ruby 2.5 in to Guix.
>>>
>>> I've put up a patch here [1], and tried it locally. I've pushed some
>>> fixes to master to make some packages compatible [2], and while I do get
>>> some failures when building the 958 (according to guix refresh -l)
>>> dependant packages, I'm unsure how many of these are down to the Ruby
>>> upgrade.
>>>
>>> 1: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32871
>>> 2: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32870
>>>
>>> Anyway, looking at the contributing guide this is possibly too big of a
>>> change to push directly to master, so should I push this to the staging
>>> branch?
>>
>> I've now gone ahead and pushed to staging. Not really sure what happens
>> now.... will berlin and hydra pick this up automatically, and start
>> building packages?
>
> So, I'm still interested in pushing Ruby 2.5 forward. I've now pushed an
> upgrade from 2.5.1 to 2.5.3 to the staging branch, as that seemed
> sensible.

Thank you for taking care of Ruby :-)

> I can see that ci.guix.info (berlin) has picked this up (I think here
> [1]), but I'm not sure what to do next...?

I can start this branch on Hydra tomorrow or Monday (it's busy
currently).  If there are no regressions, it should be safe to merge.

We need to synchronize the build farms until users have migrated to
Berlin, since many users probably only have Hydra still.

PS: Staging is currently at ~3500 rebuilds[*], which is way more than
the usual ~1200 rebuilds.  If there are other heavy-impact patches
pending that does not significantly increase this number, we might be
able to squeeze them in.

[*] According to "guix refresh -l -e '(@@ (gnu packages build-tools)
meson-for-build)' boost ruby eudev mesa wayland imagemagick openblas nss"

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]