From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petter Subject: Re: [PATCH] gnu: Add cool-retro-term. Date: Sat, 6 May 2017 00:58:57 +0200 Message-ID: <20170506005857.578fdfda@mykolab.ch> References: <20170423135526.5ed9d143@mykolab.ch> <87inlvhr0y.fsf@gmail.com> <20170423231207.4adb15e7@mykolab.ch> <87vapuwvj0.fsf@gmail.com> <20170424143026.53563696@mykolab.ch> <20170425223627.47d5a3fc@centurylink.net> <20170426200933.45340e03@mykolab.ch> <20170427204754.10212a01@centurylink.net> <20170428141037.6a4038f6@mykolab.ch> <20170502085106.434f29ff@centurylink.net> <20170503143753.0b40c54b@mykolab.ch> <20170504220324.46b64183@centurylink.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/QXBwL=/WNr5DfXZy.q3S3i5"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6mBy-0005s1-PP for guix-devel@gnu.org; Fri, 05 May 2017 18:59:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6mBu-00030m-TJ for guix-devel@gnu.org; Fri, 05 May 2017 18:59:18 -0400 Received: from mx.kolabnow.com ([95.128.36.1]:29816 helo=mx-out03.mykolab.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6mBu-0002zT-HG for guix-devel@gnu.org; Fri, 05 May 2017 18:59:14 -0400 In-Reply-To: <20170504220324.46b64183@centurylink.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Eric Bavier Cc: guix-devel@gnu.org --Sig_/QXBwL=/WNr5DfXZy.q3S3i5 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Eric, On Thu, 4 May 2017 22:03:24 -0500 Eric Bavier wrote: > Hello Petter, >=20 > Pushed as f9ff014bf623071b9343265e8a5aa994a10ec9d4 ! Cool! :) > I ended up whitelisting a few more of the fonts, after verifying their > licenses, and made some more specific notes on the license of each > font. Nice! I appreciate you taking care of this. My interest and knowledge of licensing is pretty low, so I find this quite daunting at the moment. I'm s= ure this will be easier for me when I gain more knowledge. I see you updated both the snippet and the patch for the settings menu. Goo= d! Maybe we should start, or perhaps encourage the FSF, to maintain a list of = Free fonts. Guess this isn't the last time we need to determine a font's license. Just a thought. > I had to add $out/qml to the wrapper QML2_IMPORT_PATH in order for crt > to start up. I figured that was alright, since that path was present > in your initial patch. Hm. Yeah, it certainly looks alright; in fact it looks "too alright". I don= 't really understand now how this even can work for me without it. This is aft= er all where the qml for the embedded library is, which I assume is quite important for the program :) Aha! I had to investigate and now I get it. I've been using cool-retro-term since the first time I was able to start it. At this point I built it with (inputs qml). The wrapper at this point added only cool-retro-term/qml to QML2_IMPORT_PATH (what you've added again). And QML2_IMPORT_PATH has been s= et to this in my terminal environment ever since, and have further been includ= ed by the wrapper script when I've run later builds: export QML2_IMPORT_PATH=3D "...988icm-qtquickcontrols-5.7.1/qml${QML2_IMPORT_PATH:+:}$QML2_IMPORT_PA= TH" Now, when I went from full qml to qml components, I checked if this was sti= ll required (wasn't thinking). It built and started fine without it so I remov= ed it. Good thing you tried it! > I added the patches to dist_patch_DATA in gnu/local.mk and listed them > in the commit log too. Thanks! I'm not familiar with gnu/local.mk. Looks like a build script. I see you also changed (assoc-ref %build-inputs ..) to use "inputs". Noted! > It even builds with "--rounds=3D2" :) Yay! :) > Thanks again, > `~Eric Thanks yourself! :) Petter --Sig_/QXBwL=/WNr5DfXZy.q3S3i5 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEB+Ude/iUmL3PehPCvgTmz6aYnSEFAlkNA7EACgkQvgTmz6aY nSERXw//afY5ERFl0wyJrMUJ4WTcW18znB7EZGAx+bNC8gg3/NVIeTVPhIXISTRV ktN4RysKx3Ik9rBUib8v4TbRax/AAMTWNeu/UoeylxMtU/r14yw9zBsrNEdoXFNR z0z6tOoxBsj/TovqnIl7TaVYmhj9rOutxgv/mRqElZcPEqQbUifGaN6FctQ2vnjJ BfKIn8OALny5ICHuKsF70MVwbjhnvQJChtznN8KJjoB1DxMeyckEuK+eUQ9DiMmU edhKI4ueFW8Dewjv0HcPtnbuCBEXs7BpWXzkYIdXcaXH1K9Oq2Kefj81DmgV1qGd 0LRyCM4c/ntmWmDCb0ptQIpDbGkhzX3CVYILY92lbh1p6YMz1fWb70Rky0XBUr2S KNXD70k/1COn5NBPyCI/BHvaXx+bV2Hv9tyRMF6UiUux++8hUnOTIrLK24IvwZrn Cu5SNEopPwnOZvdBoOyUxpMGSS0HdcfEGDoCZfKraxpWk1HfGz9yx9gyNGhRoqFw Cl64WS29lXRxXXQZS966aurZv3R/J4QhF/jl7YSq9KeOjeqBXKjzAJ8v8xY85XLf 6PZQvOYln7H3apcxtxg48hEEb7+DI2ngqiNqCjIXlP689gDU0q0Gkpm9h+a6AeBV 68+jj2pAoWCakVGJ3X7GbcIz6A/Wtq47XZfPSaXiCuIRdvvCork= =JHe5 -----END PGP SIGNATURE----- --Sig_/QXBwL=/WNr5DfXZy.q3S3i5--