unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 04/18] gnu: Add r-spams.
Date: Thu, 24 Nov 2016 23:12:49 -0500	[thread overview]
Message-ID: <20161125041249.GA16816@jasmine> (raw)
In-Reply-To: <20161124165139.13740-5-rekado@elephly.net>

On Thu, Nov 24, 2016 at 05:51:25PM +0100, Ricardo Wurmus wrote:
> * gnu/packages/statistics.scm (r-spams): New variable.

> +         ;; This looks like a syntax error.
> +         (add-after 'chdir 'patch-isnan
> +           (lambda _
> +             (substitute* '"src/spams/linalg/linalg.h"
> +               (("if isnan\\(lambda\\) \\{")
> +                "if (isnan(lambda)) {"))
> +             #t)))))

Has this been reported upstream? :)

LGTM regardless.

  reply	other threads:[~2016-11-25  4:13 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24 16:51 [PATCH 00/18] Add R packages Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 01/18] gnu: Add r-rematch Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 02/18] gnu: Add r-cellranger Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 03/18] gnu: Add r-googlesheets Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 04/18] gnu: Add r-spams Ricardo Wurmus
2016-11-25  4:12   ` Leo Famulari [this message]
2016-11-28 21:39     ` Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 05/18] gnu: Add r-r4rna Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 06/18] gnu: Add r-dynamictreecut Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 07/18] gnu: Add r-preprocesscore Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 08/18] gnu: Add r-fastcluster Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 09/18] gnu: Add r-wgcna Ricardo Wurmus
2016-11-25 10:38   ` Ben Woodcroft
2016-11-28 21:45     ` Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 10/18] gnu: Add r-sfsmisc Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 11/18] gnu: Add r-kernlab Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 12/18] gnu: Add r-gtools Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 13/18] gnu: Add r-chipkernels Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 14/18] gnu: Add r-seqgl Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 15/18] gnu: Add r-gdata Ricardo Wurmus
2016-11-25  4:17   ` Leo Famulari
2016-11-24 16:51 ` [PATCH 16/18] gnu: Add r-gplots Ricardo Wurmus
2016-11-25  4:16   ` Leo Famulari
2016-11-25 22:53     ` Ludovic Courtès
2016-11-28 21:47       ` Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 17/18] gnu: Add r-rocr Ricardo Wurmus
2016-11-24 16:51 ` [PATCH 18/18] gnu: Add r-gkmsvm Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161125041249.GA16816@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).