Re: [PATCH 09/18] gnu: Add r-wgcna.

[Ricardo Wurmus <rekado@elephly.net>]

Ben Woodcroft <b.woodcroft@uq.edu.au> writes:

> On 25/11/16 02:51, Ricardo Wurmus wrote:
>> [..]
>> +    (home-page
>> +     "http://www.genetics.ucla.edu/labs/horvath/CoexpressionNetwork/Rpackages/WGCNA/")
> This line is a bit long, I don't remember, should it be split over two 
> lines?

True, but I left it as it is.  It’s just a tiny bit too long and we
don’t usually split home-page strings, so I opted to keep it like this.

>> +    (synopsis "Weighted correlation network analysis")
>> +    (description
>> +     "This package provides functions necessary to perform Weighted
>> +Correlation Network Analysis on high-dimensional data.  It includes functions
>> +for rudimentary data cleaning, construction of correlation networks, module
>> +identification, summarization, and relating of variables and modules to sample
> I found the 'and' a bit confusing. Maybe:
>
> It includes functions for rudimentary data cleaning, construction and 
> summarization of correlation networks, module identification and 
> functions for relating both variables and modules to sample traits.

Thanks for the improved sentence.  I’ve updated the description.

>> +traits.  It also includes a number of utility functions for data manipulation
>> +and visualization.")
>> +    (license license:gpl2+)))
>> +
>>   (define-public emboss
>>     (package
>>       (name "emboss")
> LGTM, I have one just like it locally.
> ben

Cool, thanks for the review!

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net