From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 04/18] gnu: Add r-spams.
Date: Thu, 24 Nov 2016 23:12:49 -0500
Message-ID: <20161125041249.GA16816@jasmine>
References: <20161124165139.13740-1-rekado@elephly.net>
	<20161124165139.13740-5-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cA7sk-0001GI-0v
	for guix-devel@gnu.org; Thu, 24 Nov 2016 23:13:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cA7sf-0007xC-I8
	for guix-devel@gnu.org; Thu, 24 Nov 2016 23:13:01 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40964)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cA7sf-0007vi-C1
	for guix-devel@gnu.org; Thu, 24 Nov 2016 23:12:57 -0500
Content-Disposition: inline
In-Reply-To: <20161124165139.13740-5-rekado@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

On Thu, Nov 24, 2016 at 05:51:25PM +0100, Ricardo Wurmus wrote:
> * gnu/packages/statistics.scm (r-spams): New variable.

> +         ;; This looks like a syntax error.
> +         (add-after 'chdir 'patch-isnan
> +           (lambda _
> +             (substitute* '"src/spams/linalg/linalg.h"
> +               (("if isnan\\(lambda\\) \\{")
> +                "if (isnan(lambda)) {"))
> +             #t)))))

Has this been reported upstream? :)

LGTM regardless.