[PATCH] gnu: Add taskwarrior.

[PATCH] gnu: Add taskwarrior.

[Tomáš Čech]

* gnu/packages/task.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add new file here.
---
 gnu-system.am         |  1 +
 gnu/packages/task.scm | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)
 create mode 100644 gnu/packages/task.scm

diff --git a/gnu-system.am b/gnu-system.am
index 2175605..f4c92dd 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -273,6 +273,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/swig.scm				\
   gnu/packages/sxiv.scm				\
   gnu/packages/synergy.scm			\
+  gnu/packages/task.scm				\
   gnu/packages/tbb.scm				\
   gnu/packages/tcl.scm				\
   gnu/packages/tcsh.scm				\
diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
new file mode 100644
index 0000000..7fa1628
--- /dev/null
+++ b/gnu/packages/task.scm
@@ -0,0 +1,64 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages mail)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages lua)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake)
+  )
+
+(define-public taskwarrior
+  (package
+    (name "taskwarrior")
+    (version "2.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://taskwarrior.org/download/task-" version ".tar.gz"))
+       (sha256 (base32
+                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("util-linux" ,util-linux)
+       ("gnutls" ,gnutls)
+       ("lua" ,lua)
+       ("coreutils" ,coreutils)
+       ))
+;;    (native-inputs
+;;     `(("pkg-config" ,pkg-config)))
+    (arguments
+     `(#:phases
+       (alist-cons-before
+        'patch-source-shebangs 'remove-broken-symlinks
+        (lambda _
+          (delete-file "src/cal")
+          (delete-file "src/calendar")
+          (delete-file "src/tw"))
+        (alist-delete 'check %standard-phases))))
+    (home-page "http://taskwarrior.org")
+    (synopsis
+     "Simple and easy to use SMTP client with decent sendmail compatibility")
+    (description
+     "msmtp is an SMTP client.  In the default mode, it transmits a mail to
+an SMTP server (for example at a free mail provider) which takes care of further
+delivery.")
+    (license license:expat)))
-- 
2.2.1

(unknown),

[Tomáš Čech]

I haven't seen any further reaction for 12 days so I hope you don't mind that
I resend it again.

[PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

From: Tomáš Čech <sleep_walker@suse.cz>

* gnu/packages/task.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am         |  1 +
 gnu/packages/task.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 gnu/packages/task.scm

diff --git a/gnu-system.am b/gnu-system.am
index 1f2ebdf..d25c4df 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -275,6 +275,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/swig.scm				\
   gnu/packages/sxiv.scm				\
   gnu/packages/synergy.scm			\
+  gnu/packages/task.scm				\
   gnu/packages/tbb.scm				\
   gnu/packages/tcl.scm				\
   gnu/packages/tcsh.scm				\
diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
new file mode 100644
index 0000000..af14b14
--- /dev/null
+++ b/gnu/packages/task.scm
@@ -0,0 +1,67 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages task)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages lua)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake)
+  )
+
+(define-public taskwarrior
+  (package
+    (name "taskwarrior")
+    (version "2.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://taskwarrior.org/download/task-" version ".tar.gz"))
+       (sha256 (base32
+                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("gnutls" ,gnutls)
+       ("lua" ,lua)
+       ("util-linux" ,util-linux)))
+    (arguments
+     `(#:tests? #f ; skip tests
+       #:phases
+       (alist-cons-before
+        'patch-source-shebangs 'remove-broken-symlinks
+        (lambda _
+          ;; these files are broken symlinks - lets just delete them
+          (delete-file "src/cal")
+          (delete-file "src/calendar")
+          (delete-file "src/tw"))
+        %standard-phases)))
+    (home-page "http://taskwarrior.org")
+    (synopsis
+     "Command line task manager")
+    (description
+     "Taskwarrior is mature command line task manager following Getting Things
+Done time management method.  It supports network synchronization, filtering
+and quering data, exposing task data in multiple formats to other tools which
+allowed to create healthy ecosystem of tools using taskwarrior.")
+    ;; Taskwarrior is licensed under MIT license, which is identical to
+    ;; Expat License
+    (license license:expat)))
-- 
2.2.1

Re: [PATCH v2] gnu: Add taskwarrior.

[Cyril Roelandt]

Sorry for the delay in reviewing this.

On 03/25/2015 11:49 PM, Tomáš Čech wrote:
> From: Tomáš Čech <sleep_walker@suse.cz>
> 
> * gnu/packages/task.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> ---
>  gnu-system.am         |  1 +
>  gnu/packages/task.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 68 insertions(+)
>  create mode 100644 gnu/packages/task.scm
> 
> diff --git a/gnu-system.am b/gnu-system.am
> index 1f2ebdf..d25c4df 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -275,6 +275,7 @@ GNU_SYSTEM_MODULES =				\
>    gnu/packages/swig.scm				\
>    gnu/packages/sxiv.scm				\
>    gnu/packages/synergy.scm			\
> +  gnu/packages/task.scm				\
>    gnu/packages/tbb.scm				\
>    gnu/packages/tcl.scm				\
>    gnu/packages/tcsh.scm				\
> diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
> new file mode 100644
> index 0000000..af14b14
> --- /dev/null
> +++ b/gnu/packages/task.scm
> @@ -0,0 +1,67 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages task)

Why is this module called "task"?

> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (gnu packages base)
> +  #:use-module (gnu packages gnutls)
> +  #:use-module (gnu packages linux)
> +  #:use-module (gnu packages lua)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system cmake)
> +  )

This parenthesis should be moved to the previous line.

> +
> +(define-public taskwarrior
> +  (package
> +    (name "taskwarrior")
> +    (version "2.4.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://taskwarrior.org/download/task-" version ".tar.gz"))
> +       (sha256 (base32
> +                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
> +    (build-system cmake-build-system)
> +    (inputs
> +     `(("gnutls" ,gnutls)
> +       ("lua" ,lua)
> +       ("util-linux" ,util-linux)))
> +    (arguments
> +     `(#:tests? #f ; skip tests

Why are the tests skipped? The comment should be more verbose.

> +       #:phases
> +       (alist-cons-before
> +        'patch-source-shebangs 'remove-broken-symlinks
> +        (lambda _
> +          ;; these files are broken symlinks - lets just delete them
> +          (delete-file "src/cal")
> +          (delete-file "src/calendar")
> +          (delete-file "src/tw"))
> +        %standard-phases)))
> +    (home-page "http://taskwarrior.org")
> +    (synopsis
> +     "Command line task manager")
> +    (description
> +     "Taskwarrior is mature command line task manager following Getting Things
> +Done time management method.  It supports network synchronization, filtering
> +and quering data, exposing task data in multiple formats to other tools which
> +allowed to create healthy ecosystem of tools using taskwarrior.")
> +    ;; Taskwarrior is licensed under MIT license, which is identical to
> +    ;; Expat License
> +    (license license:expat)))
> 

Cyril.

Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 4275 bytes --]

On Thu, Mar 26, 2015 at 12:01:26AM +0100, Cyril Roelandt wrote:
>Sorry for the delay in reviewing this.
>
>On 03/25/2015 11:49 PM, Tomáš Čech wrote:
>> From: Tomáš Čech <sleep_walker@suse.cz>
>>
>> * gnu/packages/task.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>> ---
>>  gnu-system.am         |  1 +
>>  gnu/packages/task.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 68 insertions(+)
>>  create mode 100644 gnu/packages/task.scm
>>
>> diff --git a/gnu-system.am b/gnu-system.am
>> index 1f2ebdf..d25c4df 100644
>> --- a/gnu-system.am
>> +++ b/gnu-system.am
>> @@ -275,6 +275,7 @@ GNU_SYSTEM_MODULES =				\
>>    gnu/packages/swig.scm				\
>>    gnu/packages/sxiv.scm				\
>>    gnu/packages/synergy.scm			\
>> +  gnu/packages/task.scm				\
>>    gnu/packages/tbb.scm				\
>>    gnu/packages/tcl.scm				\
>>    gnu/packages/tcsh.scm				\
>> diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
>> new file mode 100644
>> index 0000000..af14b14
>> --- /dev/null
>> +++ b/gnu/packages/task.scm
>> @@ -0,0 +1,67 @@
>> +;;; GNU Guix --- Functional package management for GNU
>> +;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
>> +;;;
>> +;;; This file is part of GNU Guix.
>> +;;;
>> +;;; GNU Guix is free software; you can redistribute it and/or modify it
>> +;;; under the terms of the GNU General Public License as published by
>> +;;; the Free Software Foundation; either version 3 of the License, or (at
>> +;;; your option) any later version.
>> +;;;
>> +;;; GNU Guix is distributed in the hope that it will be useful, but
>> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
>> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +;;; GNU General Public License for more details.
>> +;;;
>> +;;; You should have received a copy of the GNU General Public License
>> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>> +
>> +(define-module (gnu packages task)
>
>Why is this module called "task"?

Idea was task as for task management. Would task-management be better?

>
>> +  #:use-module ((guix licenses) #:prefix license:)
>> +  #:use-module (guix packages)
>> +  #:use-module (gnu packages base)
>> +  #:use-module (gnu packages gnutls)
>> +  #:use-module (gnu packages linux)
>> +  #:use-module (gnu packages lua)
>> +  #:use-module (guix download)
>> +  #:use-module (guix build-system cmake)
>> +  )
>
>This parenthesis should be moved to the previous line.

Thanks.

>> +
>> +(define-public taskwarrior
>> +  (package
>> +    (name "taskwarrior")
>> +    (version "2.4.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "http://taskwarrior.org/download/task-" version ".tar.gz"))
>> +       (sha256 (base32
>> +                "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
>> +    (build-system cmake-build-system)
>> +    (inputs
>> +     `(("gnutls" ,gnutls)
>> +       ("lua" ,lua)
>> +       ("util-linux" ,util-linux)))
>> +    (arguments
>> +     `(#:tests? #f ; skip tests
>
>Why are the tests skipped? The comment should be more verbose.

No tests implemented. Thanks - fixed.
>
>> +       #:phases
>> +       (alist-cons-before
>> +        'patch-source-shebangs 'remove-broken-symlinks
>> +        (lambda _
>> +          ;; these files are broken symlinks - lets just delete them
>> +          (delete-file "src/cal")
>> +          (delete-file "src/calendar")
>> +          (delete-file "src/tw"))
>> +        %standard-phases)))
>> +    (home-page "http://taskwarrior.org")
>> +    (synopsis
>> +     "Command line task manager")
>> +    (description
>> +     "Taskwarrior is mature command line task manager following Getting Things
>> +Done time management method.  It supports network synchronization, filtering
>> +and quering data, exposing task data in multiple formats to other tools which
>> +allowed to create healthy ecosystem of tools using taskwarrior.")
>> +    ;; Taskwarrior is licensed under MIT license, which is identical to
>> +    ;; Expat License
>> +    (license license:expat)))
>>
>
>Cyril.
>
>

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH v2] gnu: Add taskwarrior.

[Ludovic Courtès]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> From: Tomáš Čech <sleep_walker@suse.cz>
>
> * gnu/packages/task.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

To complement Cyril’s review:

> +(define-module (gnu packages task)

‘task-management’, as you proposed, would be better.  Would there be
other packages in there?

> +    (description
> +     "Taskwarrior is mature command line task manager following Getting Things

Missing articles: “a mature”, “following the Getting Things Done ... method”.

> +Done time management method.  It supports network synchronization, filtering
> +and quering data, exposing task data in multiple formats to other tools which
> +allowed to create healthy ecosystem of tools using taskwarrior.")

Please remove “which allowed ...” (marketing stuff.)

> +    ;; Taskwarrior is licensed under MIT license, which is identical to
> +    ;; Expat License

Please remove this comment.  It’s just that “MIT license” is an
ambiguous name for the Expat license.

Could you send an updated patch?

Thanks!

Ludo’.

Re: none

[Ludovic Courtès]

Tomáš Čech <sleep_walker@gnu.org> skribis:

> I haven't seen any further reaction for 12 days so I hope you don't mind that
> I resend it again.

Reaction to what?

Ludo’.

Re: none

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

On Thu, Mar 26, 2015 at 10:22:36PM +0100, Ludovic Courtès wrote:
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> I haven't seen any further reaction for 12 days so I hope you don't mind that
>> I resend it again.
>
>Reaction to what?

Reaction to the first patch version.

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

[PATCH] gnu: Add taskwarrior.

[Tomáš Čech]

From: Tomáš Čech <sleep_walker@suse.cz>

* gnu/packages/task-management.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am                    |  1 +
 gnu/packages/task-management.scm | 63 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 64 insertions(+)
 create mode 100644 gnu/packages/task-management.scm

diff --git a/gnu-system.am b/gnu-system.am
index 6fdd60d..ae4b41d 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -277,6 +277,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/swig.scm				\
   gnu/packages/sxiv.scm				\
   gnu/packages/synergy.scm			\
+  gnu/packages/task-management.scm		\
   gnu/packages/tbb.scm				\
   gnu/packages/tcl.scm				\
   gnu/packages/tcsh.scm				\
diff --git a/gnu/packages/task-management.scm b/gnu/packages/task-management.scm
new file mode 100644
index 0000000..278fd7c
--- /dev/null
+++ b/gnu/packages/task-management.scm
@@ -0,0 +1,63 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages task-management)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages lua)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake))
+
+(define-public taskwarrior
+  (package
+    (name "taskwarrior")
+    (version "2.4.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://taskwarrior.org/download/task-" version ".tar.gz"))
+       (sha256 (base32
+                "03d57zzjq0m0gr4cr6vzmdz1zwpk9rvmmpgm8vk9czzrdwrwl7i7"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("gnutls" ,gnutls)
+       ("lua" ,lua)
+       ("util-linux" ,util-linux)))
+    (arguments
+     `(#:tests? #f ; No tests implemented.
+       #:phases
+       (alist-cons-before
+        'patch-source-shebangs 'remove-broken-symlinks
+        (lambda _
+          ;; These files are broken symlinks - delete them.
+          (delete-file "src/cal")
+          (delete-file "src/calendar")
+          (delete-file "src/tw"))
+        %standard-phases)))
+    (home-page "http://taskwarrior.org")
+    (synopsis
+     "Command line task manager")
+    (description
+     "Taskwarrior is a mature command line task manager following the Getting Things
+Done time management method.  It supports network synchronization, filtering
+and querying data, exposing task data in multiple formats to other tools.")
+    (license license:expat)))
-- 
2.2.1

Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Thu, Mar 26, 2015 at 06:03:45PM +0100, Ludovic Courtès wrote:
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> From: Tomáš Čech <sleep_walker@suse.cz>
>>
>> * gnu/packages/task.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
>To complement Cyril’s review:
>
>> +(define-module (gnu packages task)
>
>‘task-management’, as you proposed, would be better.  Would there be
>other packages in there?

I don't plan more packages ATM.

>> +    (description
>> +     "Taskwarrior is mature command line task manager following Getting Things
>
>Missing articles: “a mature”, “following the Getting Things Done ... method”.

Fixed.

>
>> +Done time management method.  It supports network synchronization, filtering
>> +and quering data, exposing task data in multiple formats to other tools which
>> +allowed to create healthy ecosystem of tools using taskwarrior.")
>
>Please remove “which allowed ...” (marketing stuff.)

Fixed. (it's my opinion, not marketing :)
>
>> +    ;; Taskwarrior is licensed under MIT license, which is identical to
>> +    ;; Expat License
>
>Please remove this comment.  It’s just that “MIT license” is an
>ambiguous name for the Expat license.

I'm really not friend of this. But I asked authors and they don't mind
call their license Expat in spite of their choice so I changed that as
you wish.

>Could you send an updated patch?

Sent.

Tomas

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

On Fri, Mar 27, 2015 at 08:54:08PM +0100, Tomáš Čech wrote:
>On Thu, Mar 26, 2015 at 06:03:45PM +0100, Ludovic Courtès wrote:
>>Could you send an updated patch?
>
>Sent.

I can't find patch version 3 in ML so I'd rather resend it. If I'm
only selectively and temporary blind, please, just ignore that.

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

[PATCH] gnu: Add taskwarrior.

[Tomáš Čech]

* gnu/packages/task-management.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am                    |  1 +
 gnu/packages/task-management.scm | 63 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 64 insertions(+)
 create mode 100644 gnu/packages/task-management.scm

diff --git a/gnu-system.am b/gnu-system.am
index ccc755b..dbd9c5d 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -279,6 +279,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/swig.scm				\
   gnu/packages/sxiv.scm				\
   gnu/packages/synergy.scm			\
+  gnu/packages/task-management.scm		\
   gnu/packages/tbb.scm				\
   gnu/packages/tcl.scm				\
   gnu/packages/tcsh.scm				\
diff --git a/gnu/packages/task-management.scm b/gnu/packages/task-management.scm
new file mode 100644
index 0000000..278fd7c
--- /dev/null
+++ b/gnu/packages/task-management.scm
@@ -0,0 +1,63 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages task-management)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages lua)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake))
+
+(define-public taskwarrior
+  (package
+    (name "taskwarrior")
+    (version "2.4.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://taskwarrior.org/download/task-" version ".tar.gz"))
+       (sha256 (base32
+                "03d57zzjq0m0gr4cr6vzmdz1zwpk9rvmmpgm8vk9czzrdwrwl7i7"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("gnutls" ,gnutls)
+       ("lua" ,lua)
+       ("util-linux" ,util-linux)))
+    (arguments
+     `(#:tests? #f ; No tests implemented.
+       #:phases
+       (alist-cons-before
+        'patch-source-shebangs 'remove-broken-symlinks
+        (lambda _
+          ;; These files are broken symlinks - delete them.
+          (delete-file "src/cal")
+          (delete-file "src/calendar")
+          (delete-file "src/tw"))
+        %standard-phases)))
+    (home-page "http://taskwarrior.org")
+    (synopsis
+     "Command line task manager")
+    (description
+     "Taskwarrior is a mature command line task manager following the Getting Things
+Done time management method.  It supports network synchronization, filtering
+and querying data, exposing task data in multiple formats to other tools.")
+    (license license:expat)))
-- 
2.2.1

Re: [PATCH] gnu: Add taskwarrior.

[Eric Bavier]

On 2015-04-20 15:50, Tomáš Čech wrote:
> * gnu/packages/task-management.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> +(define-module (gnu packages task-management)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (gnu packages base)

^ Is this module needed?  I don't see any references to symbols it 
provides.

> +    (arguments
> +     `(#:tests? #f ; No tests implemented.
> +       #:phases
> +       (alist-cons-before
> +        'patch-source-shebangs 'remove-broken-symlinks
> +        (lambda _
> +          ;; These files are broken symlinks - delete them.
> +          (delete-file "src/cal")
> +          (delete-file "src/calendar")
> +          (delete-file "src/tw"))
> +        %standard-phases)))

You could use the new 'modify-phases' ;)

> +    (synopsis
> +     "Command line task manager")

Perhaps this on one line.

> +    (description
> +     "Taskwarrior is a mature command line task manager following the

s/command line/command-line/.  And maybe drop the "mature".

I've started using this software recently, and have found it quite 
useful, so I'm glad we're getting a Guix package for it.  :)

Thanks,
-- 
`~Eric

[PATCH] gnu: Add taskwarrior.

[Tomáš Čech]

* gnu/packages/task-management.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am                    |  1 +
 gnu/packages/task-management.scm | 61 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+)
 create mode 100644 gnu/packages/task-management.scm

diff --git a/gnu-system.am b/gnu-system.am
index ae6b4e2..cbc89c6 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -279,6 +279,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/swig.scm				\
   gnu/packages/sxiv.scm				\
   gnu/packages/synergy.scm			\
+  gnu/packages/task-management.scm		\
   gnu/packages/tbb.scm				\
   gnu/packages/tcl.scm				\
   gnu/packages/tcsh.scm				\
diff --git a/gnu/packages/task-management.scm b/gnu/packages/task-management.scm
new file mode 100644
index 0000000..e77aecb
--- /dev/null
+++ b/gnu/packages/task-management.scm
@@ -0,0 +1,61 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages task-management)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (gnu packages gnutls)
+  #:use-module (gnu packages linux)
+  #:use-module (gnu packages lua)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake))
+
+(define-public taskwarrior
+  (package
+    (name "taskwarrior")
+    (version "2.4.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://taskwarrior.org/download/task-" version ".tar.gz"))
+       (sha256 (base32
+                "1lkbw2fhshynbl7hppar1viapyrs712s14xhd8p3l8gyhvxbh0mv"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("gnutls" ,gnutls)
+       ("lua" ,lua)
+       ("util-linux" ,util-linux)))
+    (arguments
+     `(#:tests? #f ; No tests implemented.
+       #:phases
+       (modify-phases %standard-phases
+         (add-before
+          'patch-source-shebangs 'remove-broken-symlinks
+          (lambda _
+            ;; These files are broken symlinks - delete them.
+            (delete-file "src/cal")
+            (delete-file "src/calendar")
+            (delete-file "src/tw"))))))
+     (home-page "http://taskwarrior.org")
+    (synopsis "Command line task manager")
+    (description
+     "Taskwarrior is a command-line task manager following the Getting Things
+Done time management method.  It supports network synchronization, filtering
+and querying data, exposing task data in multiple formats to other tools.")
+    (license license:expat)))
-- 
2.3.5

Re: [PATCH] gnu: Add taskwarrior.

[Ludovic Courtès]

Tomáš Čech <sleep_walker@suse.cz> skribis:

> * gnu/packages/task-management.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

Please push, thanks!

Ludo'.