Re: [PATCH] gnu: Add taskwarrior.

[Eric Bavier <ericbavier@openmailbox.org>]

On 2015-04-20 15:50, Tomáš Čech wrote:
> * gnu/packages/task-management.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> +(define-module (gnu packages task-management)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (gnu packages base)

^ Is this module needed?  I don't see any references to symbols it 
provides.

> +    (arguments
> +     `(#:tests? #f ; No tests implemented.
> +       #:phases
> +       (alist-cons-before
> +        'patch-source-shebangs 'remove-broken-symlinks
> +        (lambda _
> +          ;; These files are broken symlinks - delete them.
> +          (delete-file "src/cal")
> +          (delete-file "src/calendar")
> +          (delete-file "src/tw"))
> +        %standard-phases)))

You could use the new 'modify-phases' ;)

> +    (synopsis
> +     "Command line task manager")

Perhaps this on one line.

> +    (description
> +     "Taskwarrior is a mature command line task manager following the

s/command line/command-line/.  And maybe drop the "mature".

I've started using this software recently, and have found it quite 
useful, so I'm glad we're getting a Guix package for it.  :)

Thanks,
-- 
`~Eric