unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: "Tomáš Čech" <sleep_walker@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v2] gnu: Add taskwarrior.
Date: Thu, 26 Mar 2015 18:03:45 +0100	[thread overview]
Message-ID: <874mp7adxq.fsf@gnu.org> (raw)
In-Reply-To: <1427323784-9803-2-git-send-email-sleep_walker@gnu.org> ("Tomáš	Čech"'s message of "Wed, 25 Mar 2015 23:49:44 +0100")

Tomáš Čech <sleep_walker@gnu.org> skribis:

> From: Tomáš Čech <sleep_walker@suse.cz>
>
> * gnu/packages/task.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

To complement Cyril’s review:

> +(define-module (gnu packages task)

‘task-management’, as you proposed, would be better.  Would there be
other packages in there?

> +    (description
> +     "Taskwarrior is mature command line task manager following Getting Things

Missing articles: “a mature”, “following the Getting Things Done ... method”.

> +Done time management method.  It supports network synchronization, filtering
> +and quering data, exposing task data in multiple formats to other tools which
> +allowed to create healthy ecosystem of tools using taskwarrior.")

Please remove “which allowed ...” (marketing stuff.)

> +    ;; Taskwarrior is licensed under MIT license, which is identical to
> +    ;; Expat License

Please remove this comment.  It’s just that “MIT license” is an
ambiguous name for the Expat license.

Could you send an updated patch?

Thanks!

Ludo’.

  parent reply	other threads:[~2015-03-26 17:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 22:49 (unknown), Tomáš Čech
2015-03-25 22:49 ` [PATCH v2] gnu: Add taskwarrior Tomáš Čech
2015-03-25 23:01   ` Cyril Roelandt
2015-03-25 23:16     ` Tomáš Čech
2015-03-26 17:03   ` Ludovic Courtès [this message]
2015-03-27 19:54     ` Tomáš Čech
2015-04-20 20:50       ` Tomáš Čech
2015-04-20 20:50       ` [PATCH] " Tomáš Čech
2015-04-21  0:19         ` Eric Bavier
2015-05-01 11:37           ` Tomáš Čech
2015-05-03 20:00             ` Ludovic Courtès
2015-03-26 21:22 ` none Ludovic Courtès
2015-03-26 21:52   ` none Tomáš Čech
  -- strict thread matches above, loose matches on Subject: below --
2015-03-13  0:57 taskwarrior Tomáš Čech
2015-03-13  0:57 ` [PATCH v2] gnu: Add taskwarrior Tomáš Čech
2015-03-13  6:11   ` Tomáš Čech
2015-03-13 19:16   ` Eric Bavier
2015-03-13 20:00     ` Tomáš Čech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mp7adxq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=sleep_walker@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).