From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH] gnu: Add taskwarrior.
Date: Mon, 20 Apr 2015 19:19:05 -0500
Message-ID: <bcf9c59bb130b409826765aa72fa7e8b@openmailbox.org>
References: <20150327195408.GI19723@venom.suse.cz>
	<1429563058-19861-1-git-send-email-sleep_walker@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43907)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1YkLuH-0000pw-VT
	for guix-devel@gnu.org; Mon, 20 Apr 2015 20:19:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1YkLuD-00059k-5W
	for guix-devel@gnu.org; Mon, 20 Apr 2015 20:19:17 -0400
Received: from mail2.openmailbox.org ([62.4.1.33]:43466)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1YkLuC-000590-T4
	for guix-devel@gnu.org; Mon, 20 Apr 2015 20:19:13 -0400
In-Reply-To: <1429563058-19861-1-git-send-email-sleep_walker@suse.cz>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?UTF-8?Q?Tom=C3=A1=C5=A1_=C4=8Cech?= <sleep_walker@suse.cz>
Cc: guix-devel@gnu.org

On 2015-04-20 15:50, Tom=C3=A1=C5=A1 =C4=8Cech wrote:
> * gnu/packages/task-management.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> +(define-module (gnu packages task-management)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (gnu packages base)

^ Is this module needed?  I don't see any references to symbols it=20
provides.

> +    (arguments
> +     `(#:tests? #f ; No tests implemented.
> +       #:phases
> +       (alist-cons-before
> +        'patch-source-shebangs 'remove-broken-symlinks
> +        (lambda _
> +          ;; These files are broken symlinks - delete them.
> +          (delete-file "src/cal")
> +          (delete-file "src/calendar")
> +          (delete-file "src/tw"))
> +        %standard-phases)))

You could use the new 'modify-phases' ;)

> +    (synopsis
> +     "Command line task manager")

Perhaps this on one line.

> +    (description
> +     "Taskwarrior is a mature command line task manager following the

s/command line/command-line/.  And maybe drop the "mature".

I've started using this software recently, and have found it quite=20
useful, so I'm glad we're getting a Guix package for it.  :)

Thanks,
--=20
`~Eric