From: Cyril Roelandt <tipecaml@gmail.com>
To: guix-devel@gnu.org
Subject: Re: [PATCH v2] gnu: Add taskwarrior.
Date: Thu, 26 Mar 2015 00:01:26 +0100 [thread overview]
Message-ID: <55133E46.9070701@gmail.com> (raw)
In-Reply-To: <1427323784-9803-2-git-send-email-sleep_walker@gnu.org>
Sorry for the delay in reviewing this.
On 03/25/2015 11:49 PM, Tomáš Čech wrote:
> From: Tomáš Čech <sleep_walker@suse.cz>
>
> * gnu/packages/task.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> ---
> gnu-system.am | 1 +
> gnu/packages/task.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 68 insertions(+)
> create mode 100644 gnu/packages/task.scm
>
> diff --git a/gnu-system.am b/gnu-system.am
> index 1f2ebdf..d25c4df 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -275,6 +275,7 @@ GNU_SYSTEM_MODULES = \
> gnu/packages/swig.scm \
> gnu/packages/sxiv.scm \
> gnu/packages/synergy.scm \
> + gnu/packages/task.scm \
> gnu/packages/tbb.scm \
> gnu/packages/tcl.scm \
> gnu/packages/tcsh.scm \
> diff --git a/gnu/packages/task.scm b/gnu/packages/task.scm
> new file mode 100644
> index 0000000..af14b14
> --- /dev/null
> +++ b/gnu/packages/task.scm
> @@ -0,0 +1,67 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2015 Tomáš Čech <sleep_walker@suse.cz>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages task)
Why is this module called "task"?
> + #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix packages)
> + #:use-module (gnu packages base)
> + #:use-module (gnu packages gnutls)
> + #:use-module (gnu packages linux)
> + #:use-module (gnu packages lua)
> + #:use-module (guix download)
> + #:use-module (guix build-system cmake)
> + )
This parenthesis should be moved to the previous line.
> +
> +(define-public taskwarrior
> + (package
> + (name "taskwarrior")
> + (version "2.4.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://taskwarrior.org/download/task-" version ".tar.gz"))
> + (sha256 (base32
> + "1qn2jwskrkqg3lszkcd37h06j4a1spfkr8z9yq17p59r8v34h3nr"))))
> + (build-system cmake-build-system)
> + (inputs
> + `(("gnutls" ,gnutls)
> + ("lua" ,lua)
> + ("util-linux" ,util-linux)))
> + (arguments
> + `(#:tests? #f ; skip tests
Why are the tests skipped? The comment should be more verbose.
> + #:phases
> + (alist-cons-before
> + 'patch-source-shebangs 'remove-broken-symlinks
> + (lambda _
> + ;; these files are broken symlinks - lets just delete them
> + (delete-file "src/cal")
> + (delete-file "src/calendar")
> + (delete-file "src/tw"))
> + %standard-phases)))
> + (home-page "http://taskwarrior.org")
> + (synopsis
> + "Command line task manager")
> + (description
> + "Taskwarrior is mature command line task manager following Getting Things
> +Done time management method. It supports network synchronization, filtering
> +and quering data, exposing task data in multiple formats to other tools which
> +allowed to create healthy ecosystem of tools using taskwarrior.")
> + ;; Taskwarrior is licensed under MIT license, which is identical to
> + ;; Expat License
> + (license license:expat)))
>
Cyril.
next prev parent reply other threads:[~2015-03-25 23:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 22:49 (unknown), Tomáš Čech
2015-03-25 22:49 ` [PATCH v2] gnu: Add taskwarrior Tomáš Čech
2015-03-25 23:01 ` Cyril Roelandt [this message]
2015-03-25 23:16 ` Tomáš Čech
2015-03-26 17:03 ` Ludovic Courtès
2015-03-27 19:54 ` Tomáš Čech
2015-04-20 20:50 ` Tomáš Čech
2015-04-20 20:50 ` [PATCH] " Tomáš Čech
2015-04-21 0:19 ` Eric Bavier
2015-05-01 11:37 ` Tomáš Čech
2015-05-03 20:00 ` Ludovic Courtès
2015-03-26 21:22 ` none Ludovic Courtès
2015-03-26 21:52 ` none Tomáš Čech
-- strict thread matches above, loose matches on Subject: below --
2015-03-13 0:57 taskwarrior Tomáš Čech
2015-03-13 0:57 ` [PATCH v2] gnu: Add taskwarrior Tomáš Čech
2015-03-13 6:11 ` Tomáš Čech
2015-03-13 19:16 ` Eric Bavier
2015-03-13 20:00 ` Tomáš Čech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55133E46.9070701@gmail.com \
--to=tipecaml@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).