all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Randy Taylor <dev@rjt.dev>, Eli Zaretskii <eliz@gnu.org>,
	casouri@gmail.com, 58940@debbugs.gnu.org
Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Sun, 06 Nov 2022 20:33:18 -0500	[thread overview]
Message-ID: <jwv35avzh2i.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADwFkmkM=Ffpbmbsw+262jczuofBTy=oYmy-P=Tgo+uav_R5zQ@mail.gmail.com> (Stefan Kangas's message of "Sun, 6 Nov 2022 20:24:10 +0100")

>> I suspect that's part of the reason.  Ideally, we'd phase out those old
>> `font-lock-*-face` variables rather than introduce new ones.
>> I think the only thing they bring nowadays is confusion.
> Would it be worth it to make them obsolete?

I'd be in favor, yes.

Note that most uses are within the `<foo>-font-lock-keywords` variables
where they're invisible to the byte-compiler, so users/maintainers won't
get to see very many warnings.  Maybe we could tweak
`font-lock-compile-keywords` to emit further warnings, but that will
trigger at run-time rather than compile-time :-(


        Stefan






  reply	other threads:[~2022-11-07  1:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01  1:21 bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Randy Taylor
2022-11-01  2:14 ` Yuan Fu
2022-11-02  2:04   ` Randy Taylor
2022-11-02 12:27     ` Eli Zaretskii
2022-11-05  2:46       ` Randy Taylor
2022-11-05  9:24         ` Eli Zaretskii
2022-11-06  1:00           ` Randy Taylor
2022-11-06  6:14             ` Eli Zaretskii
2022-11-06 14:05               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-06 16:43                 ` Randy Taylor
2022-11-06 19:24                 ` Stefan Kangas
2022-11-07  1:33                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-11-07  3:31                     ` Eli Zaretskii
2022-11-06  8:22             ` Eli Zaretskii
2022-11-06 17:02               ` Randy Taylor
2022-11-10  2:47                 ` Randy Taylor
2022-11-10  3:59                   ` Yuan Fu
2022-11-10 11:06                     ` Eli Zaretskii
2022-11-01 22:54 ` Dmitry Gutov
2022-11-02  2:30   ` Randy Taylor
2022-11-02 13:41     ` Dmitry Gutov
2022-11-03  2:30       ` Randy Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv35avzh2i.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=58940@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dev@rjt.dev \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.