From: Eli Zaretskii <eliz@gnu.org>
To: Randy Taylor <dev@rjt.dev>
Cc: casouri@gmail.com, 58940@debbugs.gnu.org
Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Sun, 06 Nov 2022 10:22:45 +0200 [thread overview]
Message-ID: <83v8ns1oh6.fsf@gnu.org> (raw)
In-Reply-To: <bphiiP5VjHxk8lRlveGziwtoPfo3GgpZ_qAh8Pn3uxLpibLjRDUX2rZfMLYLQBdIHs-3cU5vs_eUYw-gl903tlW9E9tyilGN_sCTpEwtaWs=@rjt.dev> (message from Randy Taylor on Sun, 06 Nov 2022 01:00:38 +0000)
> Date: Sun, 06 Nov 2022 01:00:38 +0000
> From: Randy Taylor <dev@rjt.dev>
> Cc: casouri@gmail.com, 58940@debbugs.gnu.org
>
> On Saturday, November 5th, 2022 at 05:24, Eli Zaretskii <eliz@gnu.org> wrote:
>
> > I suggest an example of an escape sequence here, ideally from 2 or
> > more programming languages.
>
> Example added, but not sure about a second programming language. Isn't it basically the same for most programming languages?
Maybe one example is enough, thanks.
> +(defface font-lock-property-face
> + '((t :inherit font-lock-variable-name-face))
> + "Font Lock mode face used to highlight properties of an object, such
> +as the declaration and use of fields in a struct."
The first line of a doc string should be a single complete sentence.
I suggest to have the detailed description be separate sentences
after the first one.
Otherwise, LGTM, thanks.
next prev parent reply other threads:[~2022-11-06 8:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 1:21 bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Randy Taylor
2022-11-01 2:14 ` Yuan Fu
2022-11-02 2:04 ` Randy Taylor
2022-11-02 12:27 ` Eli Zaretskii
2022-11-05 2:46 ` Randy Taylor
2022-11-05 9:24 ` Eli Zaretskii
2022-11-06 1:00 ` Randy Taylor
2022-11-06 6:14 ` Eli Zaretskii
2022-11-06 14:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-06 16:43 ` Randy Taylor
2022-11-06 19:24 ` Stefan Kangas
2022-11-07 1:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-07 3:31 ` Eli Zaretskii
2022-11-06 8:22 ` Eli Zaretskii [this message]
2022-11-06 17:02 ` Randy Taylor
2022-11-10 2:47 ` Randy Taylor
2022-11-10 3:59 ` Yuan Fu
2022-11-10 11:06 ` Eli Zaretskii
2022-11-01 22:54 ` Dmitry Gutov
2022-11-02 2:30 ` Randy Taylor
2022-11-02 13:41 ` Dmitry Gutov
2022-11-03 2:30 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8ns1oh6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58940@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.