From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Date: Sun, 06 Nov 2022 20:33:18 -0500 Message-ID: References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27300"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Randy Taylor , Eli Zaretskii , casouri@gmail.com, 58940@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 07 02:34:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orr1e-0006qN-RS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Nov 2022 02:34:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orr1Y-0005MY-JM; Sun, 06 Nov 2022 20:34:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orr1W-0005M5-M0 for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 20:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orr1W-0007tU-Am for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 20:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orr1W-0008Ll-6L for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 20:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2022 01:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58940-submit@debbugs.gnu.org id=B58940.166778480932059 (code B ref 58940); Mon, 07 Nov 2022 01:34:02 +0000 Original-Received: (at 58940) by debbugs.gnu.org; 7 Nov 2022 01:33:29 +0000 Original-Received: from localhost ([127.0.0.1]:60969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orr0z-0008L0-GH for submit@debbugs.gnu.org; Sun, 06 Nov 2022 20:33:29 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orr0y-0008Ko-6U for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 20:33:28 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A469D100189; Sun, 6 Nov 2022 20:33:22 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 117AF1000EF; Sun, 6 Nov 2022 20:33:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667784801; bh=BGLnGaqBF83AlGTJkw10UJNZ7xCN0PY1I+KJiQHsAA0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fH/mf3JRbHhoKq4HYkSZtWGTF8ugl5SHobkqPvO1ZaEpFH/HH6OG2RkOtP+iarW7h g9oqmg88FoRpoJlESqETJZHv9ulT+T94qv1SlrccNPt3hxZ9gtVn7C78NMaPtUwUWH 40nMSSOmxzkdg/YiZzbCI3jkp3Fxl9lo83ruvQQRJd2Ib4Cp63clKzMJWx7R2TUQWc sfLb4xd1xKBjnCXC5mWm2zyBb8soM2sMfd6iaKBMhN/n51AHZj3kTlNOKaco77Y5js w+3pCVKC30AYxOXAVfL1Ht7xoBAIWBC5s7cb2bp9HTSBJoi5pxsC4pH1IsQ0axPTSj oYaFDqzqZuLKA== Original-Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AED4612101E; Sun, 6 Nov 2022 20:33:20 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Sun, 6 Nov 2022 20:24:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247249 Archived-At: >> I suspect that's part of the reason. Ideally, we'd phase out those old >> `font-lock-*-face` variables rather than introduce new ones. >> I think the only thing they bring nowadays is confusion. > Would it be worth it to make them obsolete? I'd be in favor, yes. Note that most uses are within the `-font-lock-keywords` variables where they're invisible to the byte-compiler, so users/maintainers won't get to see very many warnings. Maybe we could tweak `font-lock-compile-keywords` to emit further warnings, but that will trigger at run-time rather than compile-time :-( Stefan