From: Randy Taylor <dev@rjt.dev>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 58940@debbugs.gnu.org
Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Thu, 03 Nov 2022 02:30:13 +0000 [thread overview]
Message-ID: <YJpLqtaEltYkueE72IRSxC1wVKCglT9zDA_87mBnTq9KMKB8cy-pqbYh7UUppDllFcYvWYuuaofityJcVgf6_tmJ_DeQoIKUZUWQk7cdwlM=@rjt.dev> (raw)
In-Reply-To: <8369bbec-8407-4785-45be-c9df239297b2@yandex.ru>
On Wednesday, November 2nd, 2022 at 09:41, Dmitry Gutov <dgutov@yandex.ru> wrote:
> This face has customizations in the default and other themes, so it can
> be useful to do something with it.
>
> It's also inherited from in highlight-escape-sequences (ELPA package).
>
> As for modes which don't do anything with escape sequences, the upside
> is that they won't be affected: no chance to break anything.
>
Sure, I think it makes sense to inherit it. Modes that don't currently do anything with escape sequences will be affected when using tree-sitter however, although it's just bold in this case, so not really a big deal. And they could just remove escape sequence highlighting in that case too, if they want.
I'll post an updated patch (with Eli's feedback) sometime tomorrow.
prev parent reply other threads:[~2022-11-03 2:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 1:21 bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Randy Taylor
2022-11-01 2:14 ` Yuan Fu
2022-11-02 2:04 ` Randy Taylor
2022-11-02 12:27 ` Eli Zaretskii
2022-11-05 2:46 ` Randy Taylor
2022-11-05 9:24 ` Eli Zaretskii
2022-11-06 1:00 ` Randy Taylor
2022-11-06 6:14 ` Eli Zaretskii
2022-11-06 14:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-06 16:43 ` Randy Taylor
2022-11-06 19:24 ` Stefan Kangas
2022-11-07 1:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-07 3:31 ` Eli Zaretskii
2022-11-06 8:22 ` Eli Zaretskii
2022-11-06 17:02 ` Randy Taylor
2022-11-10 2:47 ` Randy Taylor
2022-11-10 3:59 ` Yuan Fu
2022-11-10 11:06 ` Eli Zaretskii
2022-11-01 22:54 ` Dmitry Gutov
2022-11-02 2:30 ` Randy Taylor
2022-11-02 13:41 ` Dmitry Gutov
2022-11-03 2:30 ` Randy Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='YJpLqtaEltYkueE72IRSxC1wVKCglT9zDA_87mBnTq9KMKB8cy-pqbYh7UUppDllFcYvWYuuaofityJcVgf6_tmJ_DeQoIKUZUWQk7cdwlM=@rjt.dev' \
--to=dev@rjt.dev \
--cc=58940@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.