From: Eli Zaretskii <eliz@gnu.org>
To: Randy Taylor <dev@rjt.dev>
Cc: casouri@gmail.com, 58940@debbugs.gnu.org
Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Sat, 05 Nov 2022 11:24:29 +0200 [thread overview]
Message-ID: <83cza14uuq.fsf@gnu.org> (raw)
In-Reply-To: <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> (message from Randy Taylor on Sat, 05 Nov 2022 02:46:30 +0000)
> Date: Sat, 05 Nov 2022 02:46:30 +0000
> From: Randy Taylor <dev@rjt.dev>
> Cc: casouri@gmail.com, 58940@debbugs.gnu.org
>
> Sorry for the delay, furniture building took longer than anticipated
> and desired.
We all have our lives, no need to apologize.
> +@item font-lock-delimiter-face
> +@vindex font-lock-delimiter-face
> +for delimiters (e.g. @code{;}, @code{:}, @code{,}).
You need a comma or a @: after "e.g.", to avoid its being interpreted
as the end of a sentence.
> +@item font-lock-escape-face
> +@vindex font-lock-escape-face
> +for escape sequences in strings.
I suggest an example of an escape sequence here, ideally from 2 or
more programming languages.
> +@smallexample
> +typedef struct
> +@{
> + int prop;
> +// ^ property
> +@} obj;
> +
> +int main()
> +@{
> + obj o;
> + o.prop = 3;
> +// ^ property
> +@}
> +@end smallexample
Please use @group..@end group here, since the two parts of this can be
typeset on separate pages, but we don't want each one of thgem to be
broken between pages.
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -732,6 +732,13 @@ If the current buffer is visiting a file that is executable, the
> This determines how long to pause Emacs after a process
> filter/sentinel error has been handled.
>
> ++++
> +** New faces for font-lock.
> +'font-lock-bracket-face', 'font-lock-delimiter-face',
> +'font-lock-escape-face', 'font-lock-number-face',
> +'font-lock-misc-punctuation-face', 'font-lock-operator-face',
> +'font-lock-property-face', 'font-lock-punctuation-face'.
Should this say that they are primarily meant for use with
tree-sitter?
> +(defvar font-lock-property-face 'font-lock-property-face
> + "Face name to use for properties.")
This doc string is too concise to be useful. Please add some
information from the detailed descriptions above.
> +(defface font-lock-bracket-face
> + '((t :inherit font-lock-punctuation-face))
It is better to have the parent face font-lock-punctuation-face
defined before it is used.
Thanks.
next prev parent reply other threads:[~2022-11-05 9:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 1:21 bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Randy Taylor
2022-11-01 2:14 ` Yuan Fu
2022-11-02 2:04 ` Randy Taylor
2022-11-02 12:27 ` Eli Zaretskii
2022-11-05 2:46 ` Randy Taylor
2022-11-05 9:24 ` Eli Zaretskii [this message]
2022-11-06 1:00 ` Randy Taylor
2022-11-06 6:14 ` Eli Zaretskii
2022-11-06 14:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-06 16:43 ` Randy Taylor
2022-11-06 19:24 ` Stefan Kangas
2022-11-07 1:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-07 3:31 ` Eli Zaretskii
2022-11-06 8:22 ` Eli Zaretskii
2022-11-06 17:02 ` Randy Taylor
2022-11-10 2:47 ` Randy Taylor
2022-11-10 3:59 ` Yuan Fu
2022-11-10 11:06 ` Eli Zaretskii
2022-11-01 22:54 ` Dmitry Gutov
2022-11-02 2:30 ` Randy Taylor
2022-11-02 13:41 ` Dmitry Gutov
2022-11-03 2:30 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cza14uuq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58940@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.