From: Yuan Fu <casouri@gmail.com>
To: Randy Taylor <dev@rjt.dev>
Cc: 58940@debbugs.gnu.org
Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
Date: Mon, 31 Oct 2022 19:14:51 -0700 [thread overview]
Message-ID: <D8E9349A-E67D-4727-9644-4528261B9D37@gmail.com> (raw)
In-Reply-To: <FHp432jf0hZHIBAFEWooD8NgaaoPdq1TlfysZgbmKbNAai2EBqKUbkY-jRFHGGm4qjUjc61YF3MaSvLnKFegGFuyS8vFvJwkk-Id0O18-J4=@rjt.dev>
> On Oct 31, 2022, at 6:21 PM, Randy Taylor <dev@rjt.dev> wrote:
>
> The attached patch adds the following faces:
> • font-lock-escape-face
> • font-lock-number-face
> • font-lock-operator-face
> • font-lock-property-face
> • font-lock-punctuation-face
>
> font-lock-property-face inherits font-lock-variable-name-face which matches the behaviour of cc-mode and python-mode.
>
> font-lock-escape-face inherits nothing. In python-mode, it inherits font-lock-constant-face, but not in cc-mode. Do we want it to inherit anything?
>
> Hopefully I put everything in the right place.
>
> <0001-Add-more-font-lock-faces.patch>
Looks good! I would add a bit more explanation/example for font-lock-property-face and font-lock-punctuation-face. Eg, it’s not immediately clear to me what does preperty represent (property of an object as in obj.prop?). And it would be nice to say that punctuation-face are for commas and parenthesises.
Yuan
next prev parent reply other threads:[~2022-11-01 2:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 1:21 bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Randy Taylor
2022-11-01 2:14 ` Yuan Fu [this message]
2022-11-02 2:04 ` Randy Taylor
2022-11-02 12:27 ` Eli Zaretskii
2022-11-05 2:46 ` Randy Taylor
2022-11-05 9:24 ` Eli Zaretskii
2022-11-06 1:00 ` Randy Taylor
2022-11-06 6:14 ` Eli Zaretskii
2022-11-06 14:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-06 16:43 ` Randy Taylor
2022-11-06 19:24 ` Stefan Kangas
2022-11-07 1:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-07 3:31 ` Eli Zaretskii
2022-11-06 8:22 ` Eli Zaretskii
2022-11-06 17:02 ` Randy Taylor
2022-11-10 2:47 ` Randy Taylor
2022-11-10 3:59 ` Yuan Fu
2022-11-10 11:06 ` Eli Zaretskii
2022-11-01 22:54 ` Dmitry Gutov
2022-11-02 2:30 ` Randy Taylor
2022-11-02 13:41 ` Dmitry Gutov
2022-11-03 2:30 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8E9349A-E67D-4727-9644-4528261B9D37@gmail.com \
--to=casouri@gmail.com \
--cc=58940@debbugs.gnu.org \
--cc=dev@rjt.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.