From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Date: Thu, 03 Nov 2022 02:30:13 +0000 Message-ID: References: <8369bbec-8407-4785-45be-c9df239297b2@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29882"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58940@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 03 03:31:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqQ15-0007Vg-2b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Nov 2022 03:31:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqQ0l-0000o4-NC; Wed, 02 Nov 2022 22:31:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqQ0V-0000lE-CP for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 22:31:17 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqQ0U-0001dH-ET for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 22:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqQ0T-0005ta-Ue for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 22:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Nov 2022 02:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58940-submit@debbugs.gnu.org id=B58940.166744263022625 (code B ref 58940); Thu, 03 Nov 2022 02:31:01 +0000 Original-Received: (at 58940) by debbugs.gnu.org; 3 Nov 2022 02:30:30 +0000 Original-Received: from localhost ([127.0.0.1]:47469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqPzx-0005sq-Uk for submit@debbugs.gnu.org; Wed, 02 Nov 2022 22:30:30 -0400 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:15967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqPzv-0005sf-IM for 58940@debbugs.gnu.org; Wed, 02 Nov 2022 22:30:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667442619; x=1667701819; bh=Jtz1k+ZlOlsSFAqQpEa8bPqC28LFo+pldtnSk3W194E=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=v7zL9+bDhvB8Eeggtd17INu4THNCGjKj24kqivUhMIyGM9ktdeJQwjR/RGOIR3sIq 0EYzBZ6fENV0v4N6PTmiikaIDF+4U7RB/t0wTEK6OTjgISX+Iu3SxsYaFDG7NinrGr KvEGsvx9Mde+HINR9wxfQ6Ecg4dtGwB6wnl8KFQBC48UBOZ8QhikFnkBCzhkpM6+6/ H1fSc0cdf18ILUq/EPxdOKzwfjDS4bkFmhBwRo/On5ZkJrgsc+uOwxWtyDaqCIZQIQ ph//QMTJbrVuGfdgtSl+ilM2pmoIE5rJ3O8f36NF5oXf5SblqD3qPOU3gfSSyfCcYc IUo4OU9scEypw== In-Reply-To: <8369bbec-8407-4785-45be-c9df239297b2@yandex.ru> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246906 Archived-At: On Wednesday, November 2nd, 2022 at 09:41, Dmitry Gutov = wrote: > This face has customizations in the default and other themes, so it can > be useful to do something with it. >=20 > It's also inherited from in highlight-escape-sequences (ELPA package). >=20 > As for modes which don't do anything with escape sequences, the upside > is that they won't be affected: no chance to break anything. >=20 Sure, I think it makes sense to inherit it. Modes that don't currently do a= nything with escape sequences will be affected when using tree-sitter howev= er, although it's just bold in this case, so not really a big deal. And the= y could just remove escape sequence highlighting in that case too, if they = want. I'll post an updated patch (with Eli's feedback) sometime tomorrow.