From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Date: Mon, 31 Oct 2022 19:14:51 -0700 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18115"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58940@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 01 03:15:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opgoK-0004VW-Tu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Nov 2022 03:15:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opgny-0004bV-A3; Mon, 31 Oct 2022 22:15:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opgnw-0004at-4C for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 22:15:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opgnv-0000JZ-Rm for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 22:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opgnu-0001of-Jq for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 22:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2022 02:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58940-submit@debbugs.gnu.org id=B58940.16672689006962 (code B ref 58940); Tue, 01 Nov 2022 02:15:02 +0000 Original-Received: (at 58940) by debbugs.gnu.org; 1 Nov 2022 02:15:00 +0000 Original-Received: from localhost ([127.0.0.1]:42335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opgns-0001oE-1Y for submit@debbugs.gnu.org; Mon, 31 Oct 2022 22:15:00 -0400 Original-Received: from mail-pl1-f176.google.com ([209.85.214.176]:37779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opgnq-0001o2-PE for 58940@debbugs.gnu.org; Mon, 31 Oct 2022 22:14:59 -0400 Original-Received: by mail-pl1-f176.google.com with SMTP id d24so12344680pls.4 for <58940@debbugs.gnu.org>; Mon, 31 Oct 2022 19:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vyt0YEsI3ZNLtZ/m+KIyhZVrwbPt8QEUd2BUncA8liM=; b=m8b487Oc2gqR4fs/kxh+4MxDN038MJEAbvs33TpwlBMNOcjQKNtHz+HYXReafWGo5v sEQ0YJ8F033OL0iFfp/jNAiAfkNx+Qpk9WKQUMtx7vPTJnyogpt6LPPf1mSb44x24TEr zRh7sbPVoYH8Lf3U+qIX9QewcRPVGqZT2q/RdtX63gJ8P/9pclxEFzUuUBRee/CuytY2 19bsqMnY2qIgwEjjLnaYFnEniGuVdaOogCojVjIVJJudIBZAXp/ZSseTQWzvyqER1loA W5m+ZKlGqd+qrztUgFjb8Rea1RQbyvUW2fmvBniwxR+rWL/p+PDiM9wgPJwaN+6SBwav /M4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vyt0YEsI3ZNLtZ/m+KIyhZVrwbPt8QEUd2BUncA8liM=; b=S2RklgVx0vRs+Y5yOWkx+M9Jt2LmvVwtphlF8J03NWzNvPHr/UO2nLhsO1rsn07jZc D1yqKBlDA4sIhvpNrZouZ6b80NOobPyfiMig6SRiY81q0dnMU/d9AMR24tpkYm9Frqxx Zh4HdLdr5HtyvKqK9vTSD3xrT88bsgzKTBdkpL5243lOPFAWfK/o5OolbV32IEA1LilP /d8RTSwyUe9nlxzqCv7sxZ8O5/YWPhJIPAH5ciG6KJtmBUe7oi7kd3H8rx405Tc67u// AzEHhFbyT1tQQ1uyMsig0Q6tNavIoYFDgf7QuuVblX7w98SUGPCBXS+CZtfiBs8sOMZ4 rhVQ== X-Gm-Message-State: ACrzQf30FggnQcY1nGcEniGQWdUyqVRuBHyjF3e/YjYsWCAG9G4U1Ho9 aoxKzAi2nfkaCZifk7ikcYU= X-Google-Smtp-Source: AMsMyM5dvYj5NYE69/3fiGXl2hrxiopmShhPGrSr+32fAo5PgK3+l5mhWHy22kGTt27CihrCCHu4Sw== X-Received: by 2002:a17:90b:4d0c:b0:20b:c983:2d85 with SMTP id mw12-20020a17090b4d0c00b0020bc9832d85mr35370813pjb.45.1667268892782; Mon, 31 Oct 2022 19:14:52 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u18-20020a170902e81200b001868d4600b8sm5079462plg.158.2022.10.31.19.14.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Oct 2022 19:14:52 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246738 Archived-At: > On Oct 31, 2022, at 6:21 PM, Randy Taylor wrote: >=20 > The attached patch adds the following faces: > =E2=80=A2 font-lock-escape-face > =E2=80=A2 font-lock-number-face > =E2=80=A2 font-lock-operator-face > =E2=80=A2 font-lock-property-face > =E2=80=A2 font-lock-punctuation-face >=20 > font-lock-property-face inherits font-lock-variable-name-face which = matches the behaviour of cc-mode and python-mode. >=20 > font-lock-escape-face inherits nothing. In python-mode, it inherits = font-lock-constant-face, but not in cc-mode. Do we want it to inherit = anything? >=20 > Hopefully I put everything in the right place. >=20 > <0001-Add-more-font-lock-faces.patch> Looks good! I would add a bit more explanation/example for = font-lock-property-face and font-lock-punctuation-face. Eg, it=E2=80=99s = not immediately clear to me what does preperty represent (property of an = object as in obj.prop?). And it would be nice to say that = punctuation-face are for commas and parenthesises. Yuan=