* Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397
[not found] ` <20220904023837.68EC0C0088A@vcs2.savannah.gnu.org>
@ 2022-09-04 6:46 ` Stefan Kangas
2022-09-04 18:51 ` Lars Ingebrigtsen
2022-09-06 4:09 ` Stefan Monnier
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Kangas @ 2022-09-04 6:46 UTC (permalink / raw)
To: Stefan Monnier, Emacs developers
> branch: master
> commit 2dd1c2ab19f7fb99ecee60e27e63b2fb045f6970
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> gv.el and cl-macs.el: Fix bug#57397
>
> * lisp/emacs-lisp/gv.el (gv-get): Obey symbol macros.
> * lisp/emacs-lisp/cl-macs.el (cl--letf): Remove workaround placed to
> try and handle symbol macros.
>
> * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-test--symbol-macrolet):
> Add new testcase.
I'm not sure if it's this or something else, but I'm seeing:
Test cl-lib-symbol-macrolet-hide backtrace:
signal(ert-test-failed (((should (equal (let ((y 5)) (cl-symbol-macr
ert-fail(((should (equal (let ((y 5)) (cl-symbol-macrolet ((x y)) (l
#f(compiled-function () #<bytecode 0x942bd83acad84ee>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name cl-lib-symbol-macrolet-hide :document
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/cl-lib-te
command-line()
normal-top-level()
Test cl-lib-symbol-macrolet-hide condition:
(ert-test-failed
((should
(equal
(let ... ...)
'(5 ... ... 9)))
:form
(equal
(5
(6 5)
(6 5)
9)
(5
(6 5)
(6 6)
9))
:value nil :explanation
(list-elt 2
(list-elt 1
(different-atoms ... ...)))))
FAILED 15/46 cl-lib-symbol-macrolet-hide (0.000079 sec) at
lisp/emacs-lisp/cl-lib-tests.el:513
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397
2022-09-04 6:46 ` master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397 Stefan Kangas
@ 2022-09-04 18:51 ` Lars Ingebrigtsen
2022-09-06 4:09 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-09-04 18:51 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Stefan Monnier, Emacs developers
Stefan Kangas <stefankangas@gmail.com> writes:
>> gv.el and cl-macs.el: Fix bug#57397
>>
>> * lisp/emacs-lisp/gv.el (gv-get): Obey symbol macros.
>> * lisp/emacs-lisp/cl-macs.el (cl--letf): Remove workaround placed to
>> try and handle symbol macros.
>>
>> * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-test--symbol-macrolet):
>> Add new testcase.
>
> I'm not sure if it's this or something else, but I'm seeing:
Yes, it looks like this makes the cl-letf case fail:
(ert-deftest cl-lib-symbol-macrolet-hide ()
;; bug#26325, bug#26073
(should (equal (let ((y 5))
(cl-symbol-macrolet ((x y))
(list x
(let ((x 6)) (list x y))
(cl-letf ((x 6)) (list x y))
(apply (lambda (x) (+ x 1)) (list 8)))))
'(5 (6 5) (6 6) 9))))
It now returns (6 5). But... I'm not actually sure what the semantics
with cl-symbol-macrolet + cl-letf are supposed to be, really.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397
2022-09-04 6:46 ` master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397 Stefan Kangas
2022-09-04 18:51 ` Lars Ingebrigtsen
@ 2022-09-06 4:09 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2022-09-06 4:09 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Emacs developers
> I'm not sure if it's this or something else, but I'm seeing:
>
> Test cl-lib-symbol-macrolet-hide backtrace:
I believe this is now fixed.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-06 4:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166225911704.17882.1304401261098239437@vcs2.savannah.gnu.org>
[not found] ` <20220904023837.68EC0C0088A@vcs2.savannah.gnu.org>
2022-09-04 6:46 ` master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397 Stefan Kangas
2022-09-04 18:51 ` Lars Ingebrigtsen
2022-09-06 4:09 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.