From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397 Date: Sun, 04 Sep 2022 20:51:55 +0200 Message-ID: <87pmgb6khg.fsf@gnus.org> References: <166225911704.17882.1304401261098239437@vcs2.savannah.gnu.org> <20220904023837.68EC0C0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10449"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier , Emacs developers To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 04 20:53:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUukV-0002Ve-7L for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Sep 2022 20:53:39 +0200 Original-Received: from localhost ([::1]:35610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUukU-0004In-7r for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Sep 2022 14:53:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUuiz-00034y-FJ for emacs-devel@gnu.org; Sun, 04 Sep 2022 14:52:05 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:49946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUuiy-0007RZ-1w for emacs-devel@gnu.org; Sun, 04 Sep 2022 14:52:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eNrb3G1WQw5xNeScHaaBD3umSl9WDd7e+BcMlzMbcQk=; b=sGxnS39XlYr0u9gEcMRNDqQ8hn HU54pQOuAp2be0PzB2TZOmAkfaNPW8v3bbtA/3CgChwuiv+aGPYPt9qrsCkpEYR6aEqOzGbl7vz5X X7+Gv8CoN9vLIqJIy8dSDRHO68GdKAtdzKYBpik08b74MfkRkjZ0zOGGooHVDBK6Xio8=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUuiq-0005gE-TF; Sun, 04 Sep 2022 20:51:58 +0200 In-Reply-To: (Stefan Kangas's message of "Sun, 4 Sep 2022 08:46:13 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUaKE4fLVgmN2Uz R3VCU31Paptph7Q7UoV0l8etyuv////kMCoUAAAAAWJLR0QKaND0VgAAAAd0SU1FB+YJBBIjE6sO 5rgAAAGsSURBVDjLdZRBT8IwFMdfy4Fr20XxuHYhXhlj8gGUu0AKnDVOODIkeFYh4ywx9NvaMja7 Ot7hpe0v7//+bdcBXApESD2ghNJ6QAXnwpQyP/DPKnkWXBgwSOSI5uIngJAQggM0s63sj00/xPMC PJ8lW4C7WSTnU8sIQg+96B5glTaT3ch2mI91/ZWchhTbvkzSC6gfdKioMY5XrVD4xhVUBVn3lrZ8 UgXGORMRBP/2b2CQAnfBqdrLtwyOUpFrwKUgl9bIhWIBDdJa1rQZ9hePrGNKWEUUt5T6MEIr19SN Uj8E4uDZBddKqe0mk5/uwTfnykT25bhlKN6fwMFSMiAgjYVeP2bfqAoiQO+6/T45YFLonM48Ba11 lFMa4tDujQ3IdkoQ4KQCBGex8UVQeVnIN5lt1nKmm3ccU4DXiZzs1fHJBWiSvHR7vYEFzs8jlqnX rRz4GWDuyfjVOnFUPijvDdrT0Cjn4qU9T49YGhXf4h/Afd1Dr58B80vR9n4Ig9KndcN4MtZWUA4Q t4zo6bKocADuFMB5/tgvAINqhMVd1/8vdPjVaeCAsq58tb/g3U0o0KJpyQAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMi0wOS0wNFQxODozNToxOCswMDowMG88r48AAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjItMDktMDRUMTg6MzU6MTgrMDA6MDAeYRczAAAAAElFTkSuQmCC X-Now-Playing: Joni Mitchell's _Blue_: "A Case Of You" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294712 Archived-At: Stefan Kangas writes: >> gv.el and cl-macs.el: Fix bug#57397 >> >> * lisp/emacs-lisp/gv.el (gv-get): Obey symbol macros. >> * lisp/emacs-lisp/cl-macs.el (cl--letf): Remove workaround placed to >> try and handle symbol macros. >> >> * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-test--symbol-macrolet): >> Add new testcase. > > I'm not sure if it's this or something else, but I'm seeing: Yes, it looks like this makes the cl-letf case fail: (ert-deftest cl-lib-symbol-macrolet-hide () ;; bug#26325, bug#26073 (should (equal (let ((y 5)) (cl-symbol-macrolet ((x y)) (list x (let ((x 6)) (list x y)) (cl-letf ((x 6)) (list x y)) (apply (lambda (x) (+ x 1)) (list 8))))) '(5 (6 5) (6 6) 9)))) It now returns (6 5). But... I'm not actually sure what the semantics with cl-symbol-macrolet + cl-letf are supposed to be, really.