From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397 Date: Sun, 4 Sep 2022 08:46:13 +0200 Message-ID: References: <166225911704.17882.1304401261098239437@vcs2.savannah.gnu.org> <20220904023837.68EC0C0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22199"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 04 08:49:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUjRu-0005dM-M8 for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Sep 2022 08:49:42 +0200 Original-Received: from localhost ([::1]:51502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUjRt-00076X-75 for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Sep 2022 02:49:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUjOm-0005h9-Ol for emacs-devel@gnu.org; Sun, 04 Sep 2022 02:46:28 -0400 Original-Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]:46592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oUjOk-00069D-QZ for emacs-devel@gnu.org; Sun, 04 Sep 2022 02:46:28 -0400 Original-Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-1273a47cdb6so995751fac.13 for ; Sat, 03 Sep 2022 23:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=7wCvyHgMo4mroj0YxlBPFOQt5wro7iQEHfPtNIEmzeo=; b=UEQueL40YgMlaJAewdeAy2xdtAsIl+kxe0QIraf7vVnzyuJ0ASuBwh619QK2j6S3by bBx2X3aZML+7pwo21JfSYvpBGRbWfau667jhIkVT2iY9aVKFVkJ0At0Fj32JDQ9tb2Ad TLtEYa8ea5TKlE2GtJby9iRfgrzXu/uFF8oO6svEQ4LuEw2HQt8fmYQenoNbn8DPjnni 8Qj+vZJnx/QjNurQJhczl21IvnsGPIGbupzqLw6lYxKWpHQShg5/Ugth3ebMYwH0djW2 40SmevZlP4cFdzAeJ18tBQrOZ/Wge39/sGjliYz4iGNfjhq8z9ebVsiONphhOeARxLQa eqXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=7wCvyHgMo4mroj0YxlBPFOQt5wro7iQEHfPtNIEmzeo=; b=pbKgPzlDYOZt++F4iPj28fUb/CtqoUBmNLlN8ImnVgwSfZJdP3UjVzBXGD+eRKvxif 0upij82xHdjVDhax6imvZqzE1yhKl7uHUBD/+VGaC7bsj+hRA+ObmalEDnMTJ5Fnbxe1 M7yfdfd5FkPFwTqLhY5QjS5SogHtXqfKg7Dd4BRZewhfljmUahd5/bi+m7UEBxKy95iK NOJG5jn7UpdIEafmVAiaq6cQ5jo7Pk6QzQfKUKFa2THbf8KDUxFPt+W6tFc3BBIOCxxn BCSUFuRxQlvd9NhOj/NV9JYnCUpnH2ys/uNu8FJdejxLMk5dU2S7zyM45+i5Ujf8Y8GQ 7v/Q== X-Gm-Message-State: ACgBeo23PmryCJMHzQ1Hhz4M/XqZzbG7RYyVjdnfda3mCdzp7otrr0yf MalNjFQqD0usAB5kDvEqGId6naVYYpTwulwHyKM= X-Google-Smtp-Source: AA6agR6wr0zvFXhYbUHZHhWZHkKG5ptjQj7/iUUmKYGJMuHbKK53y+arH0Sh7eHbU/8jFSqR5eNsneBKFbmHPjpvD0o= X-Received: by 2002:a05:6870:538c:b0:11b:e64f:ee1b with SMTP id h12-20020a056870538c00b0011be64fee1bmr5775286oan.92.1662273985017; Sat, 03 Sep 2022 23:46:25 -0700 (PDT) In-Reply-To: <20220904023837.68EC0C0088A@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2001:4860:4864:20::33; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294691 Archived-At: > branch: master > commit 2dd1c2ab19f7fb99ecee60e27e63b2fb045f6970 > Author: Stefan Monnier > Commit: Stefan Monnier > > gv.el and cl-macs.el: Fix bug#57397 > > * lisp/emacs-lisp/gv.el (gv-get): Obey symbol macros. > * lisp/emacs-lisp/cl-macs.el (cl--letf): Remove workaround placed to > try and handle symbol macros. > > * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-test--symbol-macrolet): > Add new testcase. I'm not sure if it's this or something else, but I'm seeing: Test cl-lib-symbol-macrolet-hide backtrace: signal(ert-test-failed (((should (equal (let ((y 5)) (cl-symbol-macr ert-fail(((should (equal (let ((y 5)) (cl-symbol-macrolet ((x y)) (l #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name cl-lib-symbol-macrolet-hide :document ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/cl-lib-te command-line() normal-top-level() Test cl-lib-symbol-macrolet-hide condition: (ert-test-failed ((should (equal (let ... ...) '(5 ... ... 9))) :form (equal (5 (6 5) (6 5) 9) (5 (6 5) (6 6) 9)) :value nil :explanation (list-elt 2 (list-elt 1 (different-atoms ... ...))))) FAILED 15/46 cl-lib-symbol-macrolet-hide (0.000079 sec) at lisp/emacs-lisp/cl-lib-tests.el:513