From: Stefan Kangas <stefankangas@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397
Date: Sun, 4 Sep 2022 08:46:13 +0200 [thread overview]
Message-ID: <CADwFkmnQHDiWrS=B+0uniQLMJ+3d=SgvYpVYxs4RQVat_dt7dg@mail.gmail.com> (raw)
In-Reply-To: <20220904023837.68EC0C0088A@vcs2.savannah.gnu.org>
> branch: master
> commit 2dd1c2ab19f7fb99ecee60e27e63b2fb045f6970
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> gv.el and cl-macs.el: Fix bug#57397
>
> * lisp/emacs-lisp/gv.el (gv-get): Obey symbol macros.
> * lisp/emacs-lisp/cl-macs.el (cl--letf): Remove workaround placed to
> try and handle symbol macros.
>
> * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-test--symbol-macrolet):
> Add new testcase.
I'm not sure if it's this or something else, but I'm seeing:
Test cl-lib-symbol-macrolet-hide backtrace:
signal(ert-test-failed (((should (equal (let ((y 5)) (cl-symbol-macr
ert-fail(((should (equal (let ((y 5)) (cl-symbol-macrolet ((x y)) (l
#f(compiled-function () #<bytecode 0x942bd83acad84ee>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name cl-lib-symbol-macrolet-hide :document
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/cl-lib-te
command-line()
normal-top-level()
Test cl-lib-symbol-macrolet-hide condition:
(ert-test-failed
((should
(equal
(let ... ...)
'(5 ... ... 9)))
:form
(equal
(5
(6 5)
(6 5)
9)
(5
(6 5)
(6 6)
9))
:value nil :explanation
(list-elt 2
(list-elt 1
(different-atoms ... ...)))))
FAILED 15/46 cl-lib-symbol-macrolet-hide (0.000079 sec) at
lisp/emacs-lisp/cl-lib-tests.el:513
next parent reply other threads:[~2022-09-04 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166225911704.17882.1304401261098239437@vcs2.savannah.gnu.org>
[not found] ` <20220904023837.68EC0C0088A@vcs2.savannah.gnu.org>
2022-09-04 6:46 ` Stefan Kangas [this message]
2022-09-04 18:51 ` master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397 Lars Ingebrigtsen
2022-09-06 4:09 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmnQHDiWrS=B+0uniQLMJ+3d=SgvYpVYxs4RQVat_dt7dg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.