From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397
Date: Sun, 04 Sep 2022 20:51:55 +0200 [thread overview]
Message-ID: <87pmgb6khg.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmnQHDiWrS=B+0uniQLMJ+3d=SgvYpVYxs4RQVat_dt7dg@mail.gmail.com> (Stefan Kangas's message of "Sun, 4 Sep 2022 08:46:13 +0200")
Stefan Kangas <stefankangas@gmail.com> writes:
>> gv.el and cl-macs.el: Fix bug#57397
>>
>> * lisp/emacs-lisp/gv.el (gv-get): Obey symbol macros.
>> * lisp/emacs-lisp/cl-macs.el (cl--letf): Remove workaround placed to
>> try and handle symbol macros.
>>
>> * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-test--symbol-macrolet):
>> Add new testcase.
>
> I'm not sure if it's this or something else, but I'm seeing:
Yes, it looks like this makes the cl-letf case fail:
(ert-deftest cl-lib-symbol-macrolet-hide ()
;; bug#26325, bug#26073
(should (equal (let ((y 5))
(cl-symbol-macrolet ((x y))
(list x
(let ((x 6)) (list x y))
(cl-letf ((x 6)) (list x y))
(apply (lambda (x) (+ x 1)) (list 8)))))
'(5 (6 5) (6 6) 9))))
It now returns (6 5). But... I'm not actually sure what the semantics
with cl-symbol-macrolet + cl-letf are supposed to be, really.
next prev parent reply other threads:[~2022-09-04 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166225911704.17882.1304401261098239437@vcs2.savannah.gnu.org>
[not found] ` <20220904023837.68EC0C0088A@vcs2.savannah.gnu.org>
2022-09-04 6:46 ` master 2dd1c2ab19: gv.el and cl-macs.el: Fix bug#57397 Stefan Kangas
2022-09-04 18:51 ` Lars Ingebrigtsen [this message]
2022-09-06 4:09 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmgb6khg.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.