From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Date: Sun, 06 Nov 2022 10:22:45 +0200 Message-ID: <83v8ns1oh6.fsf@gnu.org> References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21033"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 58940@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 06 09:24:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oraww-0005IM-DA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Nov 2022 09:24:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orawm-0002Iq-9j; Sun, 06 Nov 2022 03:24:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orawk-0002IN-MW for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 03:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orawk-00074T-2a for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 03:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orawj-0002On-Ok for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2022 03:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Nov 2022 08:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58940-submit@debbugs.gnu.org id=B58940.16677229989153 (code B ref 58940); Sun, 06 Nov 2022 08:24:01 +0000 Original-Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 08:23:18 +0000 Original-Received: from localhost ([127.0.0.1]:58631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oraw1-0002NZ-Nj for submit@debbugs.gnu.org; Sun, 06 Nov 2022 03:23:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oraw0-0002NM-Kn for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 03:23:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oravn-00072Z-V0; Sun, 06 Nov 2022 03:23:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7btKf2Q6eeV7HtZrGhxsztPBCL0EQf1yMrbr2H52pK4=; b=LZ7/rHPyuz3D sYh4Qp8OMljllauVVHVDrFQYa0wsAHiMPRJiSyqAdRAd2BXpjWUc+8xTYJl/+qHxCnlBNq2KEAKGK Jri8JaxInupFe3VwLBUiffm1lRWY0wNB2cMwOc0I/wbQiLZkaZArPgQdlkzvJzFC7Vr69Ha+pOUqg FjszdU2oEomIwO8HYbIym+KmhHV1bw13qd2uWmd7RFb/B57dmPs4jFLeHUBHCraBLPgY0x2QzIRUN CaumDV5JucT+zPssp4EvJPRKay+Oyy1XM2Zawz5M1h38OokPaOikrHELI0ecE3iGtaDkYgrOGz/+D S2wdDoyG9SSKoN4mzyXkeA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oravm-0002h3-Uf; Sun, 06 Nov 2022 03:23:03 -0500 In-Reply-To: (message from Randy Taylor on Sun, 06 Nov 2022 01:00:38 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247193 Archived-At: > Date: Sun, 06 Nov 2022 01:00:38 +0000 > From: Randy Taylor > Cc: casouri@gmail.com, 58940@debbugs.gnu.org > > On Saturday, November 5th, 2022 at 05:24, Eli Zaretskii wrote: > > > I suggest an example of an escape sequence here, ideally from 2 or > > more programming languages. > > Example added, but not sure about a second programming language. Isn't it basically the same for most programming languages? Maybe one example is enough, thanks. > +(defface font-lock-property-face > + '((t :inherit font-lock-variable-name-face)) > + "Font Lock mode face used to highlight properties of an object, such > +as the declaration and use of fields in a struct." The first line of a doc string should be a single complete sentence. I suggest to have the detailed description be separate sentences after the first one. Otherwise, LGTM, thanks.