Re: Additional cleanup around xterm-mouse

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jared Finder via "Emacs development discussions." <emacs-devel@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, Jared Finder <jared@finder.org>
Subject: Re: Additional cleanup around xterm-mouse
Date: Sat, 21 Nov 2020 12:00:31 -0500	[thread overview]
Message-ID: <jwvzh3ay7dj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f6e874cfbf5542e47d8eddba3e732cbd@finder.org> (Jared Finder via's message of "Thu, 19 Nov 2020 00:03:30 -0800")

> The function widget-key-sequence-read-event currently does not correctly
> translate function keys for the terminal.  It has code that attempts to
> apply function-key-map, but does not apply input-decode-map, so it can not
> read function keys.  (Additionally, it should be using
> local-function-key-map now.)  Try the following steps.

It's wickedly difficult to apply those maps correctly.
The only sane way to do that it to reuse the `read-key-sequence` code,
which is why I wrote `read-key` in the first place.

I think the only sane way forward is to work on top of
`read-key-sequence`, and more specifically to start using `read-key`
much more extensively and when bumping into problems to try and fix them
in `read-key` rather than retreating to some ad-hoc hack.

        Stefan

next prev parent reply other threads:[~2020-11-21 17:00 UTC|newest]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvzh3ay7dj.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jared@finder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).