Re: Additional cleanup around xterm-mouse

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jared Finder via "Emacs development discussions." <emacs-devel@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, Jared Finder <jared@finder.org>
Subject: Re: Additional cleanup around xterm-mouse
Date: Tue, 01 Dec 2020 10:21:40 -0500	[thread overview]
Message-ID: <jwvk0u1sgwc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <0ea60a4f2a7fb0698f84ac5957cafef3@finder.org> (Jared Finder via's message of "Mon, 30 Nov 2020 23:36:23 -0800")

> I'm about 33% through analyzing read-key and have already found the
> following differences:
>
> * read-key resets this-command-keys, read-event appends to it.

I think this is a misfeature of `read-key`.  I believe the better fix is
to introduce a new function which is like `read-key-sequence` but with
fewer side effects and on top of which we would re-implement `read-key`
and `read-key-sequence`.

By "fewer side effects", I mean that it should return a set of data:
- the key-sequence read.
- the corresponding list of undecoded input-events (instead of
  modifying this-command-keys).
- the command that was found in the keymaps and which made the function
  decide that this key sequence was complete (instead of setting
  read_key_sequence_cmd).
- maybe more...

> * read-key does not return switch-frame events as they happen,
>   read-event does.

I think this is what we want.

BTW, related to that, there is `read-char` which I believe can (almost?)
always be replaced with `read-key`.


        Stefan

next prev parent reply other threads:[~2020-12-01 15:21 UTC|newest]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk0u1sgwc.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jared@finder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).