Re: Additional cleanup around xterm-mouse

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

From: Eli Zaretskii <eliz@gnu.org>
To: Jared Finder <jared@finder.org>
Cc: emacs-devel@gnu.org
Subject: Re: Additional cleanup around xterm-mouse
Date: Tue, 01 Dec 2020 20:23:07 +0200	[thread overview]
Message-ID: <83mtyxgzck.fsf@gnu.org> (raw)
In-Reply-To: <0ea60a4f2a7fb0698f84ac5957cafef3@finder.org> (message from Jared Finder on Mon, 30 Nov 2020 23:36:23 -0800)

> Date: Mon, 30 Nov 2020 23:36:23 -0800
> From: Jared Finder <jared@finder.org>
> Cc: emacs-devel@gnu.org
> 
> This makes sense to me.  I agree that read-key is likely to currently 
> behave different in some situations from read-event.  Are these 
> differences bugs that should be fixed or are they now features that can 
> not be changed?

I don't know.  I think we need to discuss each difference separately.

> I'm about 33% through analyzing read-key and have already found the 
> following differences:
> 
> * read-key resets this-command-keys, read-event appends to it.
> * read-key does not return switch-frame events as they happen, 
> read-event does.

Thank you for doing this.  We should at least document these changes
in some place, and probably also discuss at least some of them.

> Sounds good. I will modify my patch soon.

Great, thanks.

next prev parent reply other threads:[~2020-12-01 18:23 UTC|newest]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83mtyxgzck.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jared@finder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).