From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Additional cleanup around xterm-mouse Date: Sat, 21 Nov 2020 12:00:31 -0500 Message-ID: References: <83o8jupnqd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8377"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Jared Finder To: Jared Finder via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 21 18:04:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgWJV-00025r-5N for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Nov 2020 18:04:41 +0100 Original-Received: from localhost ([::1]:52950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgWJT-0002IF-SG for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Nov 2020 12:04:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgWFh-0005jZ-Qb for emacs-devel@gnu.org; Sat, 21 Nov 2020 12:00:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20961) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgWFf-0006kv-4y; Sat, 21 Nov 2020 12:00:44 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CFD25440512; Sat, 21 Nov 2020 12:00:39 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 698E244005B; Sat, 21 Nov 2020 12:00:38 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1605978038; bh=VO4L28fdBMvFKqiUCfc9lGYWbMaDQEDGJX5+7yXTPC8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cZFk9ao7TOm1eGEH6V+cuBegQy2dqLvgk9tBBe1+Aq/2FXORoyS+qLzP86fkxu6Hx phZuK6ZGBSEUYJ9RnYQ17lDH2UpekdGN/zqq1+tdduwa4cJKVzu/E1ZEh1ZZ6hbU4N oUbe8JXigpWN0lrW4g4HvEszQj630nOBluLH3iWtpyBVLs+TTOsOFanEFG6IeHFjJG N5nulsJxjV/gf/nKyubdw02fkQFySidwK16wlYA2iGxEWnOFdMJiqPBvC8vMz4P69T cl2/8MPO2rzvDPrlN/N2fx1zqd4Wpxipl4QletSk0U6HIjBYNiCcZA0GcbSwUXuNgI 7GYIeO8K0+7Bg== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 27FF6120325; Sat, 21 Nov 2020 12:00:38 -0500 (EST) In-Reply-To: (Jared Finder via's message of "Thu, 19 Nov 2020 00:03:30 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259527 Archived-At: > The function widget-key-sequence-read-event currently does not correctly > translate function keys for the terminal. It has code that attempts to > apply function-key-map, but does not apply input-decode-map, so it can not > read function keys. (Additionally, it should be using > local-function-key-map now.) Try the following steps. It's wickedly difficult to apply those maps correctly. The only sane way to do that it to reuse the `read-key-sequence` code, which is why I wrote `read-key` in the first place. I think the only sane way forward is to work on top of `read-key-sequence`, and more specifically to start using `read-key` much more extensively and when bumping into problems to try and fix them in `read-key` rather than retreating to some ad-hoc hack. Stefan