* Re: [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards [not found] <E1XB0iP-0005QR-Ey@vcs.savannah.gnu.org> @ 2014-07-27 10:21 ` Stefan Monnier 2014-07-27 11:32 ` Andreas Schwab 2014-07-27 11:46 ` Óscar Fuentes 0 siblings, 2 replies; 4+ messages in thread From: Stefan Monnier @ 2014-07-27 10:21 UTC (permalink / raw) To: Andreas Schwab; +Cc: emacs-devel > - eassert (0 <= nitems && 0 < item_size); > - if (min (PTRDIFF_MAX, SIZE_MAX) / item_size < nitems) > + eassert (nitems >= 0 && item_size > 0); > + if (nitems > min (PTRDIFF_MAX, SIZE_MAX) / item_size) [...] > - if (nitems_incr_max < incr) > + if (incr > nitems_incr_max) Why is this better? Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards 2014-07-27 10:21 ` [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards Stefan Monnier @ 2014-07-27 11:32 ` Andreas Schwab 2014-07-27 17:21 ` Stefan Monnier 2014-07-27 11:46 ` Óscar Fuentes 1 sibling, 1 reply; 4+ messages in thread From: Andreas Schwab @ 2014-07-27 11:32 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: > Why is this better? It follows the natural way the conditions are expressed. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards 2014-07-27 11:32 ` Andreas Schwab @ 2014-07-27 17:21 ` Stefan Monnier 0 siblings, 0 replies; 4+ messages in thread From: Stefan Monnier @ 2014-07-27 17:21 UTC (permalink / raw) To: Andreas Schwab; +Cc: emacs-devel >> Why is this better? > It follows the natural way the conditions are expressed. I don't see it. Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards 2014-07-27 10:21 ` [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards Stefan Monnier 2014-07-27 11:32 ` Andreas Schwab @ 2014-07-27 11:46 ` Óscar Fuentes 1 sibling, 0 replies; 4+ messages in thread From: Óscar Fuentes @ 2014-07-27 11:46 UTC (permalink / raw) To: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: >> - eassert (0 <= nitems && 0 < item_size); >> - if (min (PTRDIFF_MAX, SIZE_MAX) / item_size < nitems) >> + eassert (nitems >= 0 && item_size > 0); >> + if (nitems > min (PTRDIFF_MAX, SIZE_MAX) / item_size) > [...] >> - if (nitems_incr_max < incr) >> + if (incr > nitems_incr_max) > > Why is this better? Déjà vu: http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00670.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-27 17:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1XB0iP-0005QR-Ey@vcs.savannah.gnu.org>
2014-07-27 10:21 ` [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards Stefan Monnier
2014-07-27 11:32 ` Andreas Schwab
2014-07-27 17:21 ` Stefan Monnier
2014-07-27 11:46 ` Óscar Fuentes
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).