From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards Date: Sun, 27 Jul 2014 06:21:54 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1406456547 3129 80.91.229.3 (27 Jul 2014 10:22:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Jul 2014 10:22:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 27 12:22:19 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XBLas-0004eu-V1 for ged-emacs-devel@m.gmane.org; Sun, 27 Jul 2014 12:22:19 +0200 Original-Received: from localhost ([::1]:34460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBLas-0000hh-DH for ged-emacs-devel@m.gmane.org; Sun, 27 Jul 2014 06:22:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBLai-0000gV-Ej for emacs-devel@gnu.org; Sun, 27 Jul 2014 06:22:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBLaW-0003cO-QS for emacs-devel@gnu.org; Sun, 27 Jul 2014 06:22:08 -0400 Original-Received: from smtp-pri-03.vtxnet.net ([212.147.62.137]:53938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBLaW-0003c6-KT for emacs-devel@gnu.org; Sun, 27 Jul 2014 06:21:56 -0400 Original-Received: from localhost (unknown [127.0.0.1]) by smtp-pri-03.vtxnet.net (VTX Services SA) with ESMTP id DB13768B7BC; Sun, 27 Jul 2014 10:21:55 +0000 (UTC) Original-Received: from smtp-pri-03.vtxnet.net ([127.0.0.1]) by localhost (smtp-pri-03.vtxnet.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZSnnMyKREU1W; Sun, 27 Jul 2014 12:21:54 +0200 (CEST) Original-Received: from fmsmemgm.homelinux.net (dyn.83-228-141-040.dsl.vtx.ch [83.228.141.40]) by smtp-pri-03.vtxnet.net (VTX Services SA) with ESMTP id D868868B178; Sun, 27 Jul 2014 12:21:54 +0200 (CEST) Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id A15F0AE1BC; Sun, 27 Jul 2014 06:21:54 -0400 (EDT) In-Reply-To: (Andreas Schwab's message of "Sat, 26 Jul 2014 12:04:41 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 212.147.62.137 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173170 Archived-At: > - eassert (0 <= nitems && 0 < item_size); > - if (min (PTRDIFF_MAX, SIZE_MAX) / item_size < nitems) > + eassert (nitems >= 0 && item_size > 0); > + if (nitems > min (PTRDIFF_MAX, SIZE_MAX) / item_size) [...] > - if (nitems_incr_max < incr) > + if (incr > nitems_incr_max) Why is this better? Stefan