From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards Date: Sun, 27 Jul 2014 13:46:07 +0200 Message-ID: <87oawbnhxc.fsf@wanadoo.es> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1406461600 22731 80.91.229.3 (27 Jul 2014 11:46:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Jul 2014 11:46:40 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 27 13:46:35 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XBMuQ-0000Kw-VW for ged-emacs-devel@m.gmane.org; Sun, 27 Jul 2014 13:46:35 +0200 Original-Received: from localhost ([::1]:34622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBMuQ-0001X2-EL for ged-emacs-devel@m.gmane.org; Sun, 27 Jul 2014 07:46:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBMuJ-0001Wx-Ek for emacs-devel@gnu.org; Sun, 27 Jul 2014 07:46:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBMuA-000280-Tv for emacs-devel@gnu.org; Sun, 27 Jul 2014 07:46:27 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:53186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBMuA-00027v-N5 for emacs-devel@gnu.org; Sun, 27 Jul 2014 07:46:18 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XBMu9-0000BB-Ry for emacs-devel@gnu.org; Sun, 27 Jul 2014 13:46:17 +0200 Original-Received: from 18.red-83-41-63.dynamicip.rima-tde.net ([83.41.63.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 27 Jul 2014 13:46:17 +0200 Original-Received: from ofv by 18.red-83-41-63.dynamicip.rima-tde.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 27 Jul 2014 13:46:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 15 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 18.red-83-41-63.dynamicip.rima-tde.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:wleiEdeb1HyCN2qJ+qNohztrZu0= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:173173 Archived-At: Stefan Monnier writes: >> - eassert (0 <= nitems && 0 < item_size); >> - if (min (PTRDIFF_MAX, SIZE_MAX) / item_size < nitems) >> + eassert (nitems >= 0 && item_size > 0); >> + if (nitems > min (PTRDIFF_MAX, SIZE_MAX) / item_size) > [...] >> - if (nitems_incr_max < incr) >> + if (incr > nitems_incr_max) > > Why is this better? Déjà vu: http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00670.html