From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards
Date: Sun, 27 Jul 2014 06:21:54 -0400 [thread overview]
Message-ID: <jwv4my33xwe.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1XB0iP-0005QR-Ey@vcs.savannah.gnu.org> (Andreas Schwab's message of "Sat, 26 Jul 2014 12:04:41 +0000")
> - eassert (0 <= nitems && 0 < item_size);
> - if (min (PTRDIFF_MAX, SIZE_MAX) / item_size < nitems)
> + eassert (nitems >= 0 && item_size > 0);
> + if (nitems > min (PTRDIFF_MAX, SIZE_MAX) / item_size)
[...]
> - if (nitems_incr_max < incr)
> + if (incr > nitems_incr_max)
Why is this better?
Stefan
next parent reply other threads:[~2014-07-27 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XB0iP-0005QR-Ey@vcs.savannah.gnu.org>
2014-07-27 10:21 ` Stefan Monnier [this message]
2014-07-27 11:32 ` [Emacs-diffs] trunk r117576: Reorder conditions that are written backwards Andreas Schwab
2014-07-27 17:21 ` Stefan Monnier
2014-07-27 11:46 ` Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4my33xwe.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).