unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stefan Kangas <stefan@marxist.se>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
	emacs-devel@gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: scratch/command 064f146 1/2: Change command to interactive ... modes
Date: Wed, 17 Feb 2021 23:43:30 -0500	[thread overview]
Message-ID: <jwvr1le7zs6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADwFkmk7+FCiWOfGygA-M50BVNZr_Z69be3Aj8MuSc1Lcd-fiw@mail.gmail.com> (Stefan Kangas's message of "Wed, 17 Feb 2021 19:57:01 -0800")

>>> Please find attached a patch.
>>
>> Hm...  trying this out now, I don't think the compat macro solution
>> actually works.  That is, it works fine when byte-compiled, but not in
>> non-compiled code.  The reason for this is that `interactive-form' just
>> does a `Fassq' on the Lisp form and looks for the Qinteractive symbol.
>> Which is won't find if the symbol in `future-interactive'.
>
> It is working for me in Emacs 27, and it was working for me at the time
> when I wrote it (both byte-compiled and interpreted).
>
> I test by evaluating this in "emacs -Q":

The key here is *how* you are "evaluating", since this will determine
whether eager-macroexpansion took place or not (if it did, the code
should work, but if it didn't, it probably won't).


        Stefan




  reply	other threads:[~2021-02-18  4:43 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210213141225.11309.86562@vcs0.savannah.gnu.org>
     [not found] ` <20210213141226.EEDFE20999@vcs0.savannah.gnu.org>
2021-02-13 20:04   ` scratch/command 064f146 1/2: Change command to interactive ... modes Dmitry Gutov
2021-02-13 21:05     ` Lars Ingebrigtsen
2021-02-13 21:33       ` Dmitry Gutov
2021-02-14 15:29         ` Stefan Kangas
2021-02-14 16:03           ` Stefan Kangas
2021-02-14 16:05             ` Lars Ingebrigtsen
2021-02-14 16:17               ` Stefan Kangas
2021-02-14 16:20                 ` Lars Ingebrigtsen
2021-02-14 16:24                   ` Stefan Kangas
2021-02-14 17:25                     ` Lars Ingebrigtsen
2021-02-14 20:25                       ` Stefan Kangas
2021-02-15  3:38                         ` Eli Zaretskii
2021-02-16 12:15                           ` Lars Ingebrigtsen
2021-02-16 15:41                             ` Eli Zaretskii
2021-02-16 16:31                               ` Lars Ingebrigtsen
2021-02-16 17:03                                 ` Eli Zaretskii
2021-02-16 17:06                                   ` Lars Ingebrigtsen
2021-02-16 17:36                                     ` Eli Zaretskii
2021-02-16 17:39                                       ` Lars Ingebrigtsen
2021-02-16 17:46                                         ` Eli Zaretskii
2021-02-16 18:10                                           ` Lars Ingebrigtsen
2021-02-16 18:24                                             ` Eli Zaretskii
2021-02-16 18:36                                               ` Lars Ingebrigtsen
2021-02-16 18:49                                                 ` Eli Zaretskii
2021-02-16 19:31                                                   ` Lars Ingebrigtsen
2021-02-16 19:39                                                     ` Eli Zaretskii
2021-02-16 20:30                                                       ` Stefan Kangas
2021-02-16 20:49                                                         ` Eli Zaretskii
2021-02-16 22:00                                                           ` Lars Ingebrigtsen
2021-02-16 22:22                                                             ` Dmitry Gutov
2021-02-16 22:37                                                               ` Lars Ingebrigtsen
2021-02-17  0:48                                                                 ` Dmitry Gutov
2021-02-17 11:02                                                                   ` Lars Ingebrigtsen
2021-02-17 11:30                                                                     ` Dmitry Gutov
2021-02-17  9:10                                                                 ` Juri Linkov
2021-02-17 10:16                                                                   ` Stefan Kangas
2021-02-17 11:08                                                                     ` Lars Ingebrigtsen
2021-02-17 17:45                                                                     ` Juri Linkov
2021-02-17 18:42                                                                       ` Óscar Fuentes
2021-02-17  8:50                                                               ` Stefan Kangas
2021-02-17 13:57                                                                 ` Stefan Monnier
2021-02-17 15:52                                                                 ` Eli Zaretskii
2021-02-17 16:19                                                                 ` Dmitry Gutov
2021-02-16 22:31                                                             ` [External] : " Drew Adams
2021-02-17 16:53                                                               ` Matt Armstrong
2021-02-16 22:47                                                             ` Alan Mackenzie
2021-02-16 22:55                                                               ` Lars Ingebrigtsen
2021-02-16 23:20                                                                 ` Alan Mackenzie
2021-02-16 23:23                                                                   ` Lars Ingebrigtsen
2021-02-17 15:28                                                                   ` Eli Zaretskii
2021-02-19  5:36                                                                     ` Richard Stallman
2021-02-17 15:25                                                               ` Eli Zaretskii
2021-02-17 15:21                                                             ` Eli Zaretskii
2021-02-17 19:01                                                               ` Óscar Fuentes
2021-02-17 19:42                                                                 ` Dmitry Gutov
2021-02-17 19:49                                                                   ` Lars Ingebrigtsen
2021-02-17 19:30                                                               ` Lars Ingebrigtsen
2021-02-17 20:12                                                                 ` Eli Zaretskii
2021-02-18 23:57                                                                   ` Rolf Ade
2021-02-16 21:44                                                         ` Dmitry Gutov
2021-02-17  8:58                                                         ` Juri Linkov
2021-02-17 10:16                                                           ` Stefan Kangas
2021-02-17 11:05                                                             ` Lars Ingebrigtsen
2021-02-17 17:45                                                             ` Juri Linkov
2021-02-17 19:26                                                               ` Eli Zaretskii
2021-02-16 12:07                         ` Lars Ingebrigtsen
2021-02-17 20:05                         ` Lars Ingebrigtsen
2021-02-17 21:03                           ` Stefan Monnier
2021-02-17 21:06                             ` Lars Ingebrigtsen
2021-02-17 22:26                               ` Stefan Monnier
2021-02-18  3:57                           ` Stefan Kangas
2021-02-18  4:43                             ` Stefan Monnier [this message]
2021-02-18  5:20                               ` Stefan Kangas
2021-02-18 10:33                             ` Lars Ingebrigtsen
2021-02-18 10:38                               ` Lars Ingebrigtsen
2021-02-18 10:40                                 ` Lars Ingebrigtsen
2021-02-18 14:01                                 ` Stefan Monnier
2021-02-18 16:03                                   ` Stefan Monnier
2021-02-18 16:47                                     ` Basil L. Contovounesios
2021-02-19 12:07                                     ` Lars Ingebrigtsen
2021-02-19 14:29                                       ` Stefan Monnier
2021-02-20 12:35                                         ` Lars Ingebrigtsen
2021-02-20 14:38                                           ` Stefan Monnier
2021-02-20 15:01                                             ` Lars Ingebrigtsen
2021-02-14 20:37                   ` Jose A. Ortega Ruiz
2021-02-14 23:23                     ` Stefan Monnier
2021-02-14 16:49             ` Basil L. Contovounesios
2021-02-14 17:23               ` Stefan Kangas
2021-02-14 17:52                 ` Basil L. Contovounesios
2021-02-14 19:54                   ` Stefan Kangas
2021-02-14 16:58             ` Alan Mackenzie
2021-02-14 17:23               ` Stefan Kangas
2021-02-14 16:02       ` Óscar Fuentes
2021-02-14 16:07         ` Lars Ingebrigtsen
2021-02-14 16:23           ` Óscar Fuentes
2021-02-14 17:05             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr1le7zs6.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).