From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/command 064f146 1/2: Change command to interactive ... modes Date: Wed, 17 Feb 2021 23:43:30 -0500 Message-ID: References: <20210213141225.11309.86562@vcs0.savannah.gnu.org> <20210213141226.EEDFE20999@vcs0.savannah.gnu.org> <47209379-76df-4c97-e5ff-b3b04da0db1d@yandex.ru> <87zh07of0e.fsf@gnus.org> <0605ed62-a785-d190-caf2-2232e1db3b0f@yandex.ru> <87mtw6d480.fsf@gnus.org> <87eehid3k2.fsf@gnus.org> <87r1liblzb.fsf@gnus.org> <87czwy1mu2.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26768"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org, Dmitry Gutov To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 18 05:44:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCbAs-0006sK-6v for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 05:44:22 +0100 Original-Received: from localhost ([::1]:49268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCbAr-00087Q-8q for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 23:44:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCbA9-0007gI-0k for emacs-devel@gnu.org; Wed, 17 Feb 2021 23:43:37 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:65035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCbA6-0005cR-58 for emacs-devel@gnu.org; Wed, 17 Feb 2021 23:43:36 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1D39580976; Wed, 17 Feb 2021 23:43:33 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 971F780284; Wed, 17 Feb 2021 23:43:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1613623411; bh=T26S7/MQ4kCMPhoLR5zSzeRpxosElnjvRfp8zw2/iH4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oG9qaDkg7aiLWjOc9Gti1cpcFHTH70WpHATmj84ygHG4elOVWFXJmmCGgKSzRSLw7 89esoCI6CPlTZKdb316bVh3xAoVO9NvfPiMcfGLB+XsCkZlifR8XzZ5EY3ojxRRKNn vbsc+gizIqOYiJEqwbTGxmBMqKDUy9+sFkvYRraanHcPPJ2L4GalzaT6wWqGvNAN8f IuEIBWEtCrKeEvsJzmZgAlLoqVtEf9I2Sn5CS5i8qV9zntvRAqug28xNBDzMWKu1X3 3hLMYbS8leQxoo6WrnUrN10IuID46+bv/vTykLmQ/JbIsTNVp/4JVQAX9Ow0fVTVTU CWG6UIFVja1aQ== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4FAEC12017E; Wed, 17 Feb 2021 23:43:31 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Wed, 17 Feb 2021 19:57:01 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265123 Archived-At: >>> Please find attached a patch. >> >> Hm... trying this out now, I don't think the compat macro solution >> actually works. That is, it works fine when byte-compiled, but not in >> non-compiled code. The reason for this is that `interactive-form' just >> does a `Fassq' on the Lisp form and looks for the Qinteractive symbol. >> Which is won't find if the symbol in `future-interactive'. > > It is working for me in Emacs 27, and it was working for me at the time > when I wrote it (both byte-compiled and interpreted). > > I test by evaluating this in "emacs -Q": The key here is *how* you are "evaluating", since this will determine whether eager-macroexpansion took place or not (if it did, the code should work, but if it didn't, it probably won't). Stefan