From: "Mattias Engdegård" <mattiase@acm.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juanma Barranquero <lekktu@gmail.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: master a6b5985: Avoid duplicated character classes in rx
Date: Wed, 4 Dec 2019 12:22:31 +0100 [thread overview]
Message-ID: <FD1EE1D9-62D1-4227-ACDA-8CF70E5B8B85@acm.org> (raw)
In-Reply-To: <jwva789xuvm.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca>:
> Probably, but I still think it's bad practice to use the return value of
> an operation which is fundamentally a side-effect.
Very well, it has now been wrapped in (progn ... t).
Juanma Barranquero <lekktu@gmail.com>:
> So you've never written
>
> (if (setq var value) ...)
Not so much, but I find it harder to avoid
(while (setq v e) ...)
lacking tail-recursive loops.
> Thinking about converting it to cl-pushnew is what made me look closer at this code in
> the first place ;-)
I prefer not using cl in rx.el at all for messy bootstrap reasons. (cl-pushnew is a macro, but I'd rather not tempt fate.)
next prev parent reply other threads:[~2019-12-04 11:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191203142243.9552.27513@vcs0.savannah.gnu.org>
[not found] ` <20191203142246.0615C20A2B@vcs0.savannah.gnu.org>
2019-12-03 15:08 ` master a6b5985: Avoid duplicated character classes in rx Juanma Barranquero
2019-12-03 15:26 ` Stefan Monnier
2019-12-03 15:33 ` Mattias Engdegård
2019-12-03 16:01 ` Stefan Monnier
2019-12-03 16:06 ` Juanma Barranquero
2019-12-03 17:37 ` Eli Zaretskii
2019-12-03 17:46 ` Juanma Barranquero
2019-12-03 18:34 ` Stefan Monnier
2019-12-03 18:12 ` Drew Adams
2019-12-03 17:39 ` Stefan Monnier
2019-12-03 17:51 ` Juanma Barranquero
2019-12-03 18:36 ` Stefan Monnier
2019-12-03 18:43 ` Juanma Barranquero
2019-12-04 4:36 ` Richard Stallman
2019-12-04 5:38 ` Juanma Barranquero
2019-12-03 19:20 ` Michael Welsh Duggan
2019-12-03 20:21 ` Stefan Monnier
2019-12-04 11:22 ` Mattias Engdegård [this message]
2019-12-06 18:49 ` Juanma Barranquero
2019-12-06 19:45 ` Drew Adams
2019-12-06 20:11 ` Juanma Barranquero
2019-12-10 3:27 ` Adam Porter
2019-12-10 4:13 ` Stefan Monnier
2019-12-10 4:20 ` Adam Porter
2019-12-10 6:09 ` Juanma Barranquero
2019-12-10 6:32 ` Juanma Barranquero
2019-12-06 19:46 ` Eli Zaretskii
2019-12-07 4:48 ` Richard Stallman
2019-12-07 5:45 ` Juanma Barranquero
2019-12-07 15:18 ` Drew Adams
2019-12-08 5:13 ` Richard Stallman
2019-12-03 17:39 ` Drew Adams
2019-12-03 15:36 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FD1EE1D9-62D1-4227-ACDA-8CF70E5B8B85@acm.org \
--to=mattiase@acm.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).